Skip to content

fix: persist daemon watches across client disconnects - #1833

Open
LeoLan-Digital wants to merge 1 commit into
DeusData:mainfrom
LeoLan-Digital:fix/permanent-daemon-watch
Open

fix: persist daemon watches across client disconnects#1833
LeoLan-Digital wants to merge 1 commit into
DeusData:mainfrom
LeoLan-Digital:fix/permanent-daemon-watch

Conversation

@LeoLan-Digital

Copy link
Copy Markdown

Summary

Keep project watches alive in permanent daemon mode after the last client session disconnects.

This allows daemon-owned background file watching and indexing to continue independently of client session lifetime.

What changed

  • Preserve the physical project watch when the application runs in permanent mode
  • Keep non-permanent behavior unchanged
  • Allow watcher-triggered background indexing without an active client session
  • Retain daemon ownership of watcher-triggered jobs until completion
  • Add regression coverage for permanent daemon watch persistence

Tests

Focused daemon application suite:

  • 50 passed

Full CLI baseline comparison:

  • baseline: 280 passed, 1 failed
  • remaining known failure: tests/test_cli.c:1748
  • the same failure reproduces on the unmodified baseline and is unrelated to this change

git diff --check passes.

Behavior

Non-permanent applications retain the existing session-scoped watch lifecycle.

Permanent daemon mode now treats the physical watch as daemon-owned rather than session-owned, while project pruning and daemon shutdown still remove the watch through their existing lifecycle paths.

@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@LeoLan-Digital
LeoLan-Digital force-pushed the fix/permanent-daemon-watch branch 2 times, most recently from c3140ba to ff916e8 Compare August 25, 2026 13:14
Signed-off-by: LeoLan Digital <deine-email@example.com>
Signed-off-by: LeoLan Digital <DEINE_ECHTE_GITHUB_EMAIL>
Signed-off-by: LeoLan Digital <business@leolan.net>
@LeoLan-Digital
LeoLan-Digital force-pushed the fix/permanent-daemon-watch branch from ff916e8 to 5ca234c Compare August 25, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant