fix: persist daemon watches across client disconnects - #1833
Open
LeoLan-Digital wants to merge 1 commit into
Open
fix: persist daemon watches across client disconnects#1833LeoLan-Digital wants to merge 1 commit into
LeoLan-Digital wants to merge 1 commit into
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
LeoLan-Digital
force-pushed
the
fix/permanent-daemon-watch
branch
2 times, most recently
from
August 25, 2026 13:14
c3140ba to
ff916e8
Compare
Signed-off-by: LeoLan Digital <deine-email@example.com> Signed-off-by: LeoLan Digital <DEINE_ECHTE_GITHUB_EMAIL> Signed-off-by: LeoLan Digital <business@leolan.net>
LeoLan-Digital
force-pushed
the
fix/permanent-daemon-watch
branch
from
August 25, 2026 13:15
ff916e8 to
5ca234c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep project watches alive in permanent daemon mode after the last client session disconnects.
This allows daemon-owned background file watching and indexing to continue independently of client session lifetime.
What changed
Tests
Focused daemon application suite:
Full CLI baseline comparison:
tests/test_cli.c:1748git diff --checkpasses.Behavior
Non-permanent applications retain the existing session-scoped watch lifecycle.
Permanent daemon mode now treats the physical watch as daemon-owned rather than session-owned, while project pruning and daemon shutdown still remove the watch through their existing lifecycle paths.