Draft
Conversation
…rojects into account This is needed for NixOS/hydra#919[1], private projects can only be accessed as authenticated users (this also applies to jobsets). Without this flag, only public projects will be used to generate Terraform code. [1] NixOS/hydra#919
Rather than fetching `hydra-api.yaml` from `master`, I used it from my PR's branch[1] which should be reasonably up-to-date after I merged in latest master last week. Apparently, this also introduced a few more options, but during my local tests these didn't seem to be an issue. Also, `shell.nix` doesn't evaluate with `goimports` in the `buildInputs`, so I didn't re-format it here. [1] https://github.com/Ma27/hydra/blob/private-projects/hydra-api.yaml
grahamc
reviewed
Nov 15, 2021
| curl -X POST -c "$cookieJar" \ | ||
| "$serverRoot"/login \ | ||
| --fail --silent --show-error -o /dev/null \ | ||
| -d '{"username":"'"$username"'","password":"'"$pw"'"}' \ |
Member
There was a problem hiding this comment.
How about using jq to construct this JSON document, in case there are "s in the password?
Member
|
Overall it looks pretty good to me. Before we merge we should make sure @cole-h gets a review in as well. |
Author
|
@grahamc please keep in mind that the Hydra PR needs to be merged first :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP on purpose as it doesn't make sense to merge this without NixOS/hydra#919
Also, before we merge this, it needs some final polishing (see also the unchecked items below).
Checklist
make buildmake fmt(goimportsdoesn't seem to exist when I runnix-shelleven though nixpkgs is pinned)terraform init && terraform validate(you may need tomake installfrom the root of the project) (not yet, but I verified it with a dump of my Hydra settings that I applied againstlocalhost:63333)HYDRA_HOST=http://0.0.0.0:63333 HYDRA_USERNAME=alice HYDRA_PASSWORD=foobar make testacc(you will need to spin up a local / temporary instance of Hydra)