Skip to content

default to CNM direct send if >=7.81.0#2742

Open
brycekahle wants to merge 2 commits into
mainfrom
bryce.kahle/cnm-direct-send-default
Open

default to CNM direct send if >=7.81.0#2742
brycekahle wants to merge 2 commits into
mainfrom
bryce.kahle/cnm-direct-send-default

Conversation

@brycekahle

@brycekahle brycekahle commented Jun 17, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Enables CNM direct send if the agent version is >= 7.81.0

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed and show as "Verified" on GitHub (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)
  • For datadog chart changes, received ✅ from a member of your team

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@brycekahle brycekahle added the datadog/patch-version Patch version bump for datadog chart label Jun 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ GKE Autopilot / GDC Baseline Manifests Changed

This PR modifies GKE Autopilot or GDC baseline manifest snapshots. Before merging, confirm:

  • GKE Autopilot/GKE GDC baseline manifest diffs have been reviewed and confirmed to be supported in GKE Autopilot and the latest Datadog WorkloadAllowlist.

If changes introduce constraints not yet covered by the Datadog WorkloadAllowlist CR, gate them with {{- if not (or .Values.providers.gke.autopilot .Values.providers.gke.gdc) }} until the WorkloadAllowlist is updated.
See gke-constraints-review-guide.md for the full constraint reference.

@github-actions github-actions Bot added the chart/datadog This issue or pull request is related to the datadog chart label Jun 17, 2026
- bump version for datadog to 3.223.4 (patch-version)
- update changelog for datadog with version 3.223.4
- update readme for datadog
@brycekahle brycekahle marked this pull request as ready for review June 18, 2026 00:42
@brycekahle brycekahle requested review from a team as code owners June 18, 2026 00:42
@brycekahle brycekahle requested review from raymondeah and removed request for a team June 18, 2026 00:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b04183b702

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- {{ . }}
{{- end }}
{{- end }}
direct_send: {{ include "cnm-use-direct-send" . }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate direct send when process-agent env is customized

For CNM installs on Agent >= 7.81.0, this flips payload submission from the process-agent to system-probe, but existing agents.containers.processAgent.env/envDict overrides are only injected into the process-agent container and are not mirrored into system-probe. Users who set process-agent-specific intake/proxy/env settings will silently stop applying those settings to CNM once the tag crosses 7.81, so either keep this default off when process-agent env is customized or propagate the relevant overrides to system-probe.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart/datadog This issue or pull request is related to the datadog chart datadog/patch-version Patch version bump for datadog chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants