Expose OTLP debug configuration#2710
Open
DoumanAsh wants to merge 2 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 693486332a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
DoumanAsh
force-pushed
the
expose_otlp_verbosity_level
branch
2 times, most recently
from
1235504 to
7ec64a2
Compare
DoumanAsh
force-pushed
the
expose_otlp_verbosity_level
branch
from
7ec64a2 to
a04757e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces option to configure OTLP debug verbosity by setting DD_OTLP_CONFIG_DEBUG_VERBOSITY variable as per
https://github.com/DataDog/datadog-agent/blob/da0e2341fa553e1fe56da9c9ad0e28ab52ab0ddf/pkg/config/config_template.yaml#L5091
The default setting enables a very verbose logs into INFO and for most users it might not be desirable to waste storage on these logs
So I set it to none by default, but if you prefer to use datadog's default
basicplease let me knowWhich issue this PR fixes
Special notes for your reviewer:
Checklist
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)datadogchart changes, received ✅ from a member of your teamGitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md