feat(disk): add IOPS limiters.#1087
Open
Zenithar wants to merge 1 commit into
Open
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 842a405 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends the
DiskPressuredisruption with IOPS throttling support alongside the existing bandwidth (bytes/sec) throttling.Changes
API (
api/v1beta1/disk_pressure.go)readIOPSPerSecandwriteIOPSPerSecfields toDiskPressureThrottlingSpecGenerateArgs()to emit--read-iops-per-sec/--write-iops-per-secflagsExplain()with IOPS descriptionsInjector (
injector/disk_pressure.go)diskPressureThrottleModeRead/Write→diskPressureThrottleModeReadBps/WriteBpsto disambiguate from new IOPS modesdiskPressureThrottleModeReadIops/diskPressureThrottleModeWriteIopsenum valuesblkio.throttle.read_iops_device/blkio.throttle.write_iops_deviceriops=/wiops=key-value pairs to the unifiedio.maxfileInject()andClean()handle all four throttle modesIopsKeyobservability tag for structured loggingCLI (
cli/injector/disk_pressure.go)--read-iops-per-sec/--write-iops-per-secflagsDocs & Examples
docs/disk_pressure.mdanddocs/disruption_catalogue.mdexamples/disk_pressure_read_iops.yamlexample manifestexamples/complete.yamlCRDs
chaos.datadoghq.com_disruptions.yaml,_disruptioncrons.yaml,_disruptionrollouts.yamlCode Quality Checklist
Testing
unittests orend-to-endtests.unittests orend-to-endtests.readIOPSPerSecon a cgroups v1 node → verifyblkio.throttle.read_iops_devicewrittenwriteIOPSPerSecon a cgroups v2 node → verifyio.maxcontainswiops=