os-bsd-anysense.sh basic *ense OS support test suite#891
Merged
Conversation
Closed
matmacieje
force-pushed
the
os_bsd_anysense0002
branch
2 times, most recently
from
257e79b to
559dfb1
Compare
Author
Author
matmacieje
force-pushed
the
os_bsd_anysense0002
branch
from
559dfb1 to
cbf5c90
Compare
matmacieje
requested review from
filipleple,
krystian-hebel and
macpijan
and removed request for
krystian-hebel
filipleple
requested changes
Jul 2, 2025
matmacieje
force-pushed
the
os_bsd_anysense0002
branch
from
7edb5da to
c25de98
Compare
Member
|
LGTM now, though some CI fails with I think tkinter has to be added to EDIT: nope, this means that tkinter is not installed in the OS. Not sure how to do this on the CI machine @macpijan ? Also this would be just a temporary fix, since we need to skip semi-automated tests that use Dialogs on CI anyways |
filipleple
requested changes
Jul 8, 2025
filipleple
approved these changes
Jul 8, 2025
Member
filipleple
left a comment
filipleple
left a comment
There was a problem hiding this comment.
LGTM, @macpijan importing tkinter causes a fail in CI, but that's because a system package is missing from the runner platform. I'm not sure whether it can be resolved in this PR or we have to log onto the runner platform and install manually?
scripts/freebsd/preseed_opnsense.sh: bsdinstall customization, can be applied for OPNsense, pfSense & FreeBSD. Requires running FreeBSD-based system. lib/bios/menus.robot - added pfSense terminal GUI encoding support. Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
dasharo-compatibility/os-bsd-anysense.robot: test IDs fixed lib/bsd.robot: introducing keyword lib for FreBSD derivatives Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
dasharo-compatibility/os-pfsense.robot: preseed test and boot time test cases added dasharo-compatibility/os-opnsense.robot: boot time measure tests lib/bios/menus.py: Power state after AC loss added lib/bsd.robot: new, separate file for installer OS & shell keywords os-config/50*.py: OPNsense & pfSense prompts & credentials, incl. installer scripts/freebsd.preseed_opnsene.sh: license header added Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>
filipleple
force-pushed
the
os_bsd_anysense0002
branch
from
9d0b8a7 to
6fb1d7a
Compare
Contributor
|
Few questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/freebsd/preseed_opnsense.sh: bsdinstall customization, can be applied for OPNsense, pfSense & FreeBSD. Requires running FreeBSD-based system.
lib/bios/menus.robot - added pfSense terminal GUI encoding support.