NVC ADL-P fixes #303
Merged
Merged
Conversation
filipleple
changed the title
This was referenced Feb 12, 2026
Contributor
It isn't necessarily incompatible. I have succeeded in booting Windows when this option is enabled on certain devices. |
Add a note that the `Keep IOMMU enabled(...)` option is incompatible with Windows, making the OS unable to boot. Signed-off-by: Filip Lewinski <filip.lewinski@3mdeb.com>
Apply https://edk2.groups.io/g/devel/message/100548 in order to fix SD cards not listing as bootable devices/mountable volumes. Signed-off-by: Filip Lewinski <filip.lewinski@3mdeb.com>
filipleple
force-pushed
the
adlp_fixes
branch
from
e4deb11 to
d737a91
Compare
mkopec
approved these changes
Feb 18, 2026
SergiiDmytruk
approved these changes
Feb 18, 2026
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
Worth noting that mOverride = &BhtOverride; suppresses looking up gEdkiiSdMmcOverrideProtocolGuid which is provided by platform-specific drivers. It doesn't matter now since we don't use any alternative SD-card drivers. This just isn't a proper way of integration and probably the reason why the driver didn't get into upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Bayhub SD card driver, making SD cards bootable from EDK2. Adresses: Dasharo/dasharo-issues#454
Add a note that the
Keep IOMMU enabled(...)option is incompatible with Windows on many devices, making the OS unable to boot. This is to answer the issues: Dasharo/dasharo-issues#1771 Dasharo/dasharo-issues#641Dasharo/coreboot#846
ref: NCM-2103