Skip to content

Add the CI workflow - #471

Merged
mourisl merged 2 commits into
masterfrom
li_dev
Jul 31, 2026
Merged

Add the CI workflow#471
mourisl merged 2 commits into
masterfrom
li_dev

Conversation

@mourisl

@mourisl mourisl commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a GitHub Actions CI workflow to build HISAT2 on Ubuntu (g++/clang++) and macOS (clang++) and run a minimal smoke test (./hisat2 -h) to validate the produced binary.

Changes:

  • Introduces a new workflow CI triggered on pushes and PRs to master.
  • Adds an Ubuntu job that builds with a compiler matrix (g++/clang++) and runs a smoke test.
  • Adds a macOS job that builds with clang++ and runs the same smoke test.
Suppressed comments (1)

.github/workflows/c-cpp.yml:36

  • Same as the Ubuntu job: steps: list items need to be indented under steps, and run: must be a string (inline or block scalar). As written, this section is not valid for GitHub Actions.
    steps:
    - uses: actions/checkout@v4
    - name: build-hisat2
      run:
        make -j$(sysctl -n hw.ncpu) CXX=${{ matrix.compiler }} 

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +18 to +25
steps:
- uses: actions/checkout@v4
- name: build-hisat2
run:
make -j$(nproc) CXX=${{ matrix.compiler }}
- name: test-hisat2
run:
./hisat2 -h

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this pass the github running. So the indention is not an issue.

Comment on lines +9 to +10
env:
DEVELOPER_DIR: /Applications/Xcode.app/Contents/Developer
@mourisl
mourisl merged commit fa9a42a into master Jul 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants