Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a GitHub Actions CI workflow to build HISAT2 on Ubuntu (g++/clang++) and macOS (clang++) and run a minimal smoke test (./hisat2 -h) to validate the produced binary.
Changes:
- Introduces a new workflow
CItriggered on pushes and PRs tomaster. - Adds an Ubuntu job that builds with a compiler matrix (g++/clang++) and runs a smoke test.
- Adds a macOS job that builds with clang++ and runs the same smoke test.
Suppressed comments (1)
.github/workflows/c-cpp.yml:36
- Same as the Ubuntu job:
steps:list items need to be indented understeps, andrun:must be a string (inline or block scalar). As written, this section is not valid for GitHub Actions.
steps:
- uses: actions/checkout@v4
- name: build-hisat2
run:
make -j$(sysctl -n hw.ncpu) CXX=${{ matrix.compiler }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+25
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: build-hisat2 | ||
| run: | ||
| make -j$(nproc) CXX=${{ matrix.compiler }} | ||
| - name: test-hisat2 | ||
| run: | ||
| ./hisat2 -h |
Collaborator
Author
There was a problem hiding this comment.
It seems this pass the github running. So the indention is not an issue.
Comment on lines
+9
to
+10
| env: | ||
| DEVELOPER_DIR: /Applications/Xcode.app/Contents/Developer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.