Repository navigation
fix: use runtime evm stack - #147
Merged
Merged
Conversation
zoowii
reviewed
Nov 4, 2025
zoowii
reviewed
Nov 4, 2025
zoowii
reviewed
Nov 4, 2025
| setInsertBlock(PostBB); | ||
| } | ||
|
|
||
| void EVMMirBuilder::stackPush(Operand PushValue) { |
Contributor
There was a problem hiding this comment.
Since many other opcodes also manipulate the stack, will other instructions need to be modified?
It would be good to document a proposed solution first.
Contributor
There was a problem hiding this comment.
Evaluate the proposal document. If it has a significant impact on performance and a large impact on the code base, can we statically analyze during compilation to detect situations where the stack depth of instructions cannot be determined, and then degrade to the interpreter?
Contributor
Author
There was a problem hiding this comment.
I'll write a document first. If the backend can handle the mem2reg optimization well, I think most store and load instructions from same location would be eliminated in final output.
starwarfan
force-pushed
the
stack_fix
branch
from
November 18, 2025 06:44
35f2a3a to
3b44e67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note