Skip to content

Fix(game_sa/CEntity): Fix the virtual RemoveLighting function in CEntity for game_sa. #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrxenginner wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

Fix(game_sa/CEntity): Fix the virtual RemoveLighting function in CEntity for game_sa. #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd9eb55
Modify RemoveLighting to accept a boolean parameter
mrxenginner May 22, 2026
dae30b7
Modify RemoveLighting to accept a reset parameter
mrxenginner May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugin_sa/game_sa/CEntity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ bool CEntity::SetupLighting()
return ((bool (__thiscall *)(CEntity *))(*(void ***)this)[19])(this);
}

void CEntity::RemoveLighting()
void CEntity::RemoveLighting(bool bReset)
{
((void (__thiscall *)(CEntity *))(*(void ***)this)[20])(this);
((void (__thiscall *)(CEntity *, bool))(*(void ***)this)[20])(this, bReset);
}

void CEntity::FlagToDestroyWhenNextProcessed()
Expand Down Expand Up @@ -371,4 +371,4 @@ void CEntity::RemoveEscalatorsForEntity()
bool CEntity::IsEntityOccluded()
{
return ((bool (__thiscall *)(CEntity*))0x71FAE0)(this);
}
}
2 changes: 1 addition & 1 deletion plugin_sa/game_sa/CEntity.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class PLUGIN_API CEntity : public CPlaceable {
void PreRender();
void Render();
bool SetupLighting();
void RemoveLighting();
void RemoveLighting(bool bReset);
void FlagToDestroyWhenNextProcessed();

// funcs
Expand Down