-
-
Notifications
You must be signed in to change notification settings - Fork 114
Implement sendNote for VST, and also add a SendNote example #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c3a1aa5
Implement sendNote for VST, and also add a SendNote example
jpcima 4669c67
Make a few things const
jpcima f904fee
Move the MIDI queue outside of VST
jpcima 1adbf81
Fix the coding style where necessary
jpcima 2aa8464
Allow it to build when namespace DGL is not used
jpcima 087d7be
Implement sendNote for JACK
jpcima 8e637c6
Clean up unused variables
jpcima 1a9839e
Require pthread also on Windows
jpcima c7de707
Fixing the reference to DGL Rectangle, take 2
jpcima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * DISTRHO Plugin Framework (DPF) | ||
| * Copyright (C) 2012-2018 Filipe Coelho <falktx@falktx.com> | ||
| * | ||
| * Permission to use, copy, modify, and/or distribute this software for any purpose with | ||
| * or without fee is hereby granted, provided that the above copyright notice and this | ||
| * permission notice appear in all copies. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD | ||
| * TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN | ||
| * NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL | ||
| * DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER | ||
| * IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN | ||
| * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. | ||
| */ | ||
|
|
||
| #ifndef DISTRHO_PLUGIN_INFO_H_INCLUDED | ||
| #define DISTRHO_PLUGIN_INFO_H_INCLUDED | ||
|
|
||
| #define DISTRHO_PLUGIN_BRAND "DISTRHO" | ||
| #define DISTRHO_PLUGIN_NAME "SendNote" | ||
| #define DISTRHO_PLUGIN_URI "http://distrho.sf.net/examples/SendNote" | ||
|
|
||
| #define DISTRHO_PLUGIN_HAS_UI 1 | ||
| #define DISTRHO_PLUGIN_HAS_EMBED_UI 1 | ||
| #define DISTRHO_PLUGIN_IS_RT_SAFE 1 | ||
| #define DISTRHO_PLUGIN_NUM_INPUTS 0 | ||
| #define DISTRHO_PLUGIN_NUM_OUTPUTS 2 | ||
| #define DISTRHO_PLUGIN_WANT_MIDI_INPUT 1 | ||
| #define DISTRHO_PLUGIN_WANT_MIDI_OUTPUT 0 | ||
|
|
||
| #endif // DISTRHO_PLUGIN_INFO_H_INCLUDED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| #!/usr/bin/make -f | ||
| # Makefile for DISTRHO Plugins # | ||
| # ---------------------------- # | ||
| # Created by falkTX | ||
| # | ||
|
|
||
| # -------------------------------------------------------------- | ||
| # Project name, used for binaries | ||
|
|
||
| NAME = d_sendNote | ||
|
|
||
| # -------------------------------------------------------------- | ||
| # Files to build | ||
|
|
||
| FILES_DSP = \ | ||
| SendNoteExamplePlugin.cpp | ||
|
|
||
|
|
||
| FILES_UI = \ | ||
| SendNoteExampleUI.cpp | ||
|
|
||
| # -------------------------------------------------------------- | ||
| # Do some magic | ||
|
|
||
| include ../../Makefile.plugins.mk | ||
|
|
||
| # -------------------------------------------------------------- | ||
| # Enable all possible plugin types | ||
|
|
||
| ifeq ($(HAVE_JACK),true) | ||
| ifeq ($(HAVE_OPENGL),true) | ||
| TARGETS += jack | ||
| endif | ||
| endif | ||
|
|
||
| ifeq ($(HAVE_OPENGL),true) | ||
| TARGETS += lv2_sep | ||
| else | ||
| TARGETS += lv2_dsp | ||
| endif | ||
|
|
||
| TARGETS += vst | ||
|
|
||
| all: $(TARGETS) | ||
|
|
||
| # -------------------------------------------------------------- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # SendNote example | ||
|
|
||
| This example will show how to send MIDI notes in DPF based UIs.<br/> | ||
|
|
||
| The UI presents a row of MIDI keys which transmit note events to a synthesizer. | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why isn't this part of the class variables but allocated on the constructor?
do we pointer swap at some point? if not, there is no reason to allocate things twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on purpose, to avoid a large block in the middle of object layout.
I'm pretty sure it's a recommended practice regarding caching, especially that this buffer is not going to be touched very regularly.