CE custom changes for Winsparkle (background checking, UI changes)#2
CE custom changes for Winsparkle (background checking, UI changes)#2jaredburkeen wants to merge 1 commit intomasterfrom
Conversation
|
@loberlander This is ready too, you've seen this in a prior pull request. |
| m_updateButtonsSizer->Add | ||
| ( | ||
| m_installButton = new wxButton(this, ID_INSTALL, _("Install update")), | ||
| m_installButton = new wxButton(this, ID_INSTALL, _("Download")), |
There was a problem hiding this comment.
Just for consistency, wouldn't it be better to rename ID_INSTALL to ID_DOWNLOAD?
There was a problem hiding this comment.
I agree, that makes sense.
There was a problem hiding this comment.
You might also want to rename any related items like OnInstall().
| { | ||
| Settings::WriteConfigValue("SkipThisVersion", m_appcast.Version); | ||
| static const int ONE_HOUR_IN_SECONDS = 3600; | ||
| Settings::WriteConfigValue("UpdateInterval", ONE_HOUR_IN_SECONDS); |
There was a problem hiding this comment.
Is there a default for UpdateInterval? I.e. what happens when neither of the Remind buttons are pushed and the X (close window) is used instead?
There was a problem hiding this comment.
The default is what we set in our application when we initialize Winsparkle (24 hours).
Beyond that, if the user clicks on Remind in an hour, then the next clicks the Close button, the update interval will be 1 hour. I explained this behavior to Amber and she was OK with it.
There was a problem hiding this comment.
I am good with this as long as it is UX approved. 🖖
jaredburkeen
force-pushed
the
ce-winsparkle-stable
branch
from
b0a0259 to
0370d41
Compare
2 participants
This pull request replaces an earlier pull request:
#1
This new request is based on the stable release 0.5.2 of Winsparkle. The prior request was based off of master, which had a bug which resulted in a crash when downloading the update multiple times:
vslavik#117