Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
199a054
starting updating the pom.xml to move toe jackson3
shroffk Jul 30, 2026
e684c57
updating jackson dependencies
shroffk Jul 30, 2026
c066494
update imports com.fasterxml.jackson to tools.jackson
shroffk Jul 30, 2026
0832f5b
switch to using jackson exception JacksonException
shroffk Jul 30, 2026
202b020
Continue fixing the exception to match jackson3
shroffk Jul 30, 2026
7d07659
fix most of the instances of the ObjectMapper creation
shroffk Jul 30, 2026
4700916
fixing object mappers with added modules and mxin's
shroffk Jul 30, 2026
18495d8
fixing the more complex objectmappers
shroffk Jul 30, 2026
f857621
prepare to move to elastic 9.4.x
shroffk Jul 30, 2026
fe3e187
updating deserializers and queries to match elastic 9.x client
shroffk Jul 30, 2026
d42885e
Continued fixes of the ObjectMapper
shroffk Jul 30, 2026
31e7c7c
use the new JsonFactory
shroffk Jul 30, 2026
b755b9a
fix JsonToken usage to use new API
shroffk Jul 30, 2026
39cce4d
the services need explicit dep definition
shroffk Jul 31, 2026
26cff10
improve the mapper test to be more resilient
shroffk Jul 31, 2026
16aab05
disabling a few tests until we move to springboot4
shroffk Jul 31, 2026
257ac1b
expliclity include jackson dep, update exception types
shroffk Jul 31, 2026
08e5148
replace the legacy elastic rest client with rest5
shroffk Jul 31, 2026
9db701d
expliclity manage dep
shroffk Jul 31, 2026
f08635a
more temporary explicit dep - remove when moving to spring4
shroffk Jul 31, 2026
2fb8c08
expanding the pom to support local IT
shroffk Aug 3, 2026
7954caa
Phased upgrade of springboot
shroffk Aug 4, 2026
5723ffc
update save and restore - spring 3, jakarta
shroffk Aug 4, 2026
6188eab
spring 4.1
shroffk Aug 4, 2026
ad7a641
now try to make save and restore to spring4.1
shroffk Aug 4, 2026
b03359b
start migration to new spring security API
shroffk Aug 4, 2026
e0d2e1f
updating save and restore tests for springboot 4.1
shroffk Aug 4, 2026
d98fd57
use named path variables as required by springboot4
shroffk Aug 5, 2026
18eefbe
fix windows test for the Path calculations
shroffk Aug 5, 2026
bc14788
Add the need compiler flag "-parameter"
shroffk Aug 5, 2026
52a0484
switch some of the tests to use real SnapshotUtil
shroffk Aug 5, 2026
7ceb150
moving to jdk25 and javafx25
shroffk Aug 6, 2026
16ad5da
upgrade springdoc version
shroffk Aug 6, 2026
f75352f
updating the elastic client to 9.4.4
shroffk Aug 6, 2026
413818b
consistent switch to low level elastic rest client
shroffk Aug 6, 2026
cd3a07e
first pass of replacing elastic high level client with low level
shroffk Aug 6, 2026
86d8ee9
move sar to the low level elastic rest client
shroffk Aug 7, 2026
c82c486
switching all remaining elastic high level client usage to low level …
shroffk Aug 10, 2026
4ea5933
Merge pull request #3906 from ControlSystemStudio/jdk-25
shroffk Aug 11, 2026
26a3314
cleanup the local test docker file
shroffk Aug 18, 2026
fcd1d3b
Moving all phoebus modules to springboot 4.1.0
shroffk Aug 18, 2026
6bb1ad0
update SAR properties for elastic 9.4.4
shroffk Aug 18, 2026
cbaad62
Changes due to changed web socket connection API, which also allows f…
georgweiss Aug 20, 2026
0fa7489
Merge pull request #3907 from ControlSystemStudio/spring4
shroffk Aug 21, 2026
e183a6b
Merge remote-tracking branch 'origin/master' into jackson-upgrade
Copilot Aug 21, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions app/alarm/logging-ui/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,25 +39,23 @@
<version>6.0.0-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<!-- https://mvnrepository.com/artifact/tools.jackson.core/jackson-core -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>${jackson.version}</version>
<version>${tools.jackson.version}</version>
</dependency>
<!-- https://mvnrepository.com/artifact/tools.jackson.core/jackson-databind -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.version}</version>
<version>${tools.jackson.version}</version>
</dependency>
<!-- https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-annotations -->
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>${jackson.version}</version>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>${jackson.annotations.version}</version>
</dependency>
</dependencies>
</project>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package org.phoebus.applications.alarm.logging.ui;

import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import tools.jackson.core.type.TypeReference;
import tools.jackson.databind.DeserializationFeature;
import tools.jackson.databind.ObjectMapper;
import org.phoebus.framework.jobs.Job;
import org.phoebus.framework.jobs.JobManager;
import org.phoebus.framework.jobs.JobRunnableWithCancel;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package org.phoebus.applications.alarm.logging.ui;

import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import tools.jackson.core.type.TypeReference;
import tools.jackson.databind.DeserializationFeature;
import tools.jackson.databind.ObjectMapper;
import javafx.collections.ObservableMap;
import org.phoebus.applications.alarm.logging.ui.AlarmLogTableQueryUtil.Keys;
import org.phoebus.framework.jobs.Job;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
package org.phoebus.applications.alarm.logging.ui;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
import tools.jackson.core.JsonProcessingException;
import tools.jackson.databind.JsonNode;
import tools.jackson.databind.ObjectMapper;
import javafx.animation.KeyFrame;
import javafx.animation.KeyValue;
import javafx.animation.Timeline;
Expand Down Expand Up @@ -550,9 +549,6 @@ public void search() {

private static final ObjectMapper objectMapper = new ObjectMapper();

static {
objectMapper.registerModule(new JavaTimeModule());
}

@FXML
public void createContextMenu() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.DeserializationContext;
import com.fasterxml.jackson.databind.JsonDeserializer;
import tools.jackson.core.JsonParser;
import tools.jackson.core.JsonProcessingException;
import tools.jackson.databind.DeserializationContext;
import tools.jackson.databind.JsonDeserializer;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;

import java.io.IOException;
Expand Down
17 changes: 7 additions & 10 deletions app/alarm/model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,17 @@
<version>1.3</version>
<scope>test</scope>
</dependency>
<!-- https://mvnrepository.com/artifact/tools.jackson.core/jackson-core -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${jackson.version}</version>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${tools.jackson.version}</version>
</dependency>
<!-- https://mvnrepository.com/artifact/tools.jackson.core/jackson-databind -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>${jackson.version}</version>
<version>${tools.jackson.version}</version>
</dependency>
<dependency>
<groupId>org.apache.kafka</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.core.JsonProcessingException;
import tools.jackson.core.JacksonException;

/**
*
Expand Down Expand Up @@ -108,7 +108,7 @@ public Map<String, String> sourceMap() {
public String toString() {
try {
return objectMapper.writeValueAsString(this);
} catch (JsonProcessingException e) {
} catch (JacksonException e) {
logger.log(Level.WARNING, "failed to parse the alarm command message ", e);
}
return "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.core.JsonProcessingException;
import tools.jackson.core.JacksonException;

/**
*
Expand Down Expand Up @@ -225,7 +225,7 @@ public boolean isLeaf() {
public String toString() {
try {
return AlarmMessageUtil.objectConfigMapper.writeValueAsString(this);
} catch (JsonProcessingException e) {
} catch (JacksonException e) {
logger.log(Level.WARNING, "failed to parse the alarm config message ", e);
}
return "";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package org.phoebus.applications.alarm.messages;

import tools.jackson.core.JacksonException;

import static org.phoebus.applications.alarm.AlarmSystem.logger;
import static org.phoebus.applications.alarm.messages.AlarmMessageUtil.objectMapper;

import java.util.logging.Level;

import com.fasterxml.jackson.core.JsonProcessingException;

/** Alarm detail */
public class AlarmDetail {

Expand Down Expand Up @@ -62,7 +62,7 @@ public void setDelay(int delay) {
public String toString() {
try {
return objectMapper.writeValueAsString(this);
} catch (JsonProcessingException e) {
} catch (JacksonException e) {
logger.log(Level.WARNING, "failed to parse the alarm detail message ", e);
}
return "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.core.JsonProcessingException;
import tools.jackson.core.JacksonException;

/**
* A message which describes both state and configuration events
Expand Down Expand Up @@ -417,9 +417,9 @@ public void setDelete(String delete) {
/**
* @return json string representation of this object
*
* @throws JsonProcessingException on error
* @throws JacksonException on error
*/
public String toJson() throws JsonProcessingException {
public String toJson() throws JacksonException {
if (isConfig()) {
return objectConfigMapper.writeValueAsString(this);
} else if (isState()){
Expand All @@ -433,7 +433,7 @@ public String toJson() throws JsonProcessingException {
public String toString() {
try {
return toJson();
} catch (JsonProcessingException e) {
} catch (JacksonException e) {
logger.log(Level.WARNING, "failed to parse the alarm message ", e);
}
return "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.module.SimpleModule;
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
import tools.jackson.databind.ObjectMapper;
import tools.jackson.databind.module.SimpleModule;
import org.phoebus.applications.alarm.model.EnabledState;

import java.io.Serializable;
Expand All @@ -26,7 +25,6 @@ public class AlarmMessageUtil implements Serializable{
@JsonIgnore
static final ObjectMapper objectStateMapper = new ObjectMapper();
static {
objectStateMapper.registerModule(new JavaTimeModule());
objectStateMapper.addMixIn(AlarmMessageUtil.class, AlarmStateJsonMessage.class);
}

Expand All @@ -37,17 +35,13 @@ public class AlarmMessageUtil implements Serializable{
SimpleModule simple_module = new SimpleModule();
simple_module.addSerializer(new EnabledSerializer());

objectConfigMapper.registerModule(new JavaTimeModule());
objectConfigMapper.registerModule(simple_module);
objectConfigMapper.addMixIn(AlarmMessageUtil.class, AlarmConfigJsonMessage.class);
}

// Object mapper for all other alarm messages
@JsonIgnore
static final ObjectMapper objectMapper = new ObjectMapper();
static {
objectMapper.registerModule(new JavaTimeModule());
}

private static class AlarmStateJsonMessage {
@JsonIgnore
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.core.JsonProcessingException;
import tools.jackson.core.JacksonException;

/**
* A bean representing a alarm state message
Expand Down Expand Up @@ -206,7 +206,7 @@ public Map<String, String> sourceMap() {
public String toString() {
try {
return AlarmMessageUtil.objectStateMapper.writeValueAsString(this);
} catch (JsonProcessingException e) {
} catch (JacksonException e) {
logger.log(Level.WARNING, "failed to parse the alarm state message ", e);
}
return "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.core.JsonProcessingException;
import tools.jackson.core.JacksonException;

/** Talk message */
@JsonInclude(Include.NON_NULL)
Expand Down Expand Up @@ -56,7 +56,7 @@ public void setTalk(String talk) {
public String toString() {
try {
return objectMapper.writeValueAsString(this);
} catch (JsonProcessingException e) {
} catch (JacksonException e) {
logger.log(Level.WARNING, "failed to parse the alarm talk message ", e);
}
return "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

import static org.phoebus.applications.alarm.AlarmSystem.logger;

import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.DeserializationContext;
import com.fasterxml.jackson.core.ObjectCodec;
import com.fasterxml.jackson.databind.JsonNode;
import tools.jackson.databind.deser.std.StdDeserializer;
import tools.jackson.core.JsonParser;
import tools.jackson.core.JacksonException;
import tools.jackson.databind.DeserializationContext;
import tools.jackson.core.ObjectCodec;
import tools.jackson.databind.JsonNode;

import java.time.format.DateTimeFormatter;
import java.io.IOException;
Expand Down Expand Up @@ -39,7 +39,7 @@ public EnabledDeserializer(Class<EnabledState> t) {
}

@Override
public EnabledState deserialize(JsonParser jp, DeserializationContext ctxt) throws IOException, JsonProcessingException {
public EnabledState deserialize(JsonParser jp, DeserializationContext ctxt) throws JacksonException {
ObjectCodec oc = jp.getCodec();
JsonNode jn = oc.readTree(jp);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

import org.phoebus.applications.alarm.model.EnabledState;

import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.databind.SerializerProvider;
import com.fasterxml.jackson.databind.ser.std.StdSerializer;
import tools.jackson.core.JsonGenerator;
import tools.jackson.databind.SerializerProvider;
import tools.jackson.databind.ser.std.StdSerializer;

/**
* Serializer used for writing varied date string/boolean enabled values
Expand All @@ -27,10 +27,10 @@ public void serialize(

jgen.writeStartObject();
if (enabled_state.enabled_date != null) {
jgen.writeStringField("enabled", enabled_state.getDateString());
jgen.writeStringProperty("enabled", enabled_state.getDateString());
}
else {
jgen.writeBooleanField("enabled", enabled_state.enabled);
jgen.writeBooleanProperty("enabled", enabled_state.enabled);
}
jgen.writeEndObject();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import org.apache.kafka.common.serialization.Serializer;
import org.phoebus.applications.alarm.model.EnabledState;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.module.SimpleModule;
import tools.jackson.databind.ObjectMapper;
import tools.jackson.databind.module.SimpleModule;

/** XML Message parser */
public class MessageParser<T> implements Serializer<T>, Deserializer<T> {
Expand Down Expand Up @@ -42,7 +42,7 @@ public void configure(Map arg0, boolean arg1) {
@Override
public byte[] serialize(String topic, T message) {
if (message == null)
return null;
return null;s

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops


try {
return objectMapper.writeValueAsBytes(message);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
import org.phoebus.applications.alarm.model.TitleDetail;
import org.phoebus.applications.alarm.model.TitleDetailDelay;

import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.databind.JsonNode;
import tools.jackson.core.JsonParser;
import tools.jackson.databind.JsonNode;

/** Read alarm model from JSON
* @author Kay Kasemir
Expand Down
Loading