Gate Aspire doctor and failure logs when tests are skipped - #1505
Open
afscrome wants to merge 1 commit into
Open
Gate Aspire doctor and failure logs when tests are skipped#1505afscrome wants to merge 1 commit into
afscrome wants to merge 1 commit into
Conversation
Prevent Aspire doctor and failure log uploads from running when the Run tests step is skipped by gating those steps on the run-tests outcome. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1505Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1505" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI test workflow to avoid running failure diagnostics that assume tests executed when the job fails before the test step begins.
Changes:
- Adds an explicit step id (
run-tests) to the “Run tests” step. - Gates failure-only diagnostics (npm logs, TypeScript AppHost logs,
aspire doctor) on the test step not being skipped.
afscrome
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run testsstep in.github/workflows/tests.yamlsteps.run-tests.outcome != 'skipped'Aspire doctor, npm log upload, and TypeScript app host log upload from running when tests never startedWhy
This avoids some misleading errors where at first glance you may think that
aspire doctorcaused the CI failure, but it was really just a knock on from the tooling setup failure.