Skip to content

Bump JsonSchema.Net to 9.4.0 - #1493

Open
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/nuget/JsonSchema.Net-9.4.0
Open

Bump JsonSchema.Net to 9.4.0#1493
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/nuget/JsonSchema.Net-9.4.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 29, 2026

Copy link
Copy Markdown
Contributor

Pinned JsonSchema.Net at 9.4.0.

Release notes

Sourced from JsonSchema.Net's releases.

No release notes found for this version range.

Commits viewable in compare view.

Pinned JsonSchema.Net at 9.4.0.

Release notes

Sourced from JsonSchema.Net's releases.

No release notes found for this version range.

Commits viewable in compare view.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file skip-nuget-publish Skips publishing to NuGet when merging to the `main` branch. labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1493

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1493"

@afscrome

afscrome commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@afscrome

afscrome commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Looks like a legitimate breaking change

Error: /home/runner/work/Aspire/Aspire/tests/CommunityToolkit.Aspire.Testing/ConformanceTests.cs(361,39): error CS1503: Argument 1: cannot convert from 'System.Text.Json.Nodes.JsonNode' to 'System.Text.Json.JsonElement' [/home/runner/work/Aspire/Aspire/tests/CommunityToolkit.Aspire.Testing/CommunityToolkit.Aspire.Testing.csproj::TargetFramework=net10.0]
Error: /home/runner/work/Aspire/Aspire/tests/CommunityToolkit.Aspire.Testing/ConformanceTests.cs(374,43): error CS1503: Argument 1: cannot convert from 'System.Text.Json.Nodes.JsonNode' to 'System.Text.Json.JsonElement' [/home/runner/work/Aspire/Aspire/tests/CommunityToolkit.Aspire.Testing/CommunityToolkit.Aspire.Testing.csproj::TargetFramework=net10.0]
Error: /home/runner/work/Aspire/Aspire/tests/CommunityToolkit.Aspire.Testing/ConformanceTests.cs(375,64): error CS1061: 'EvaluationResults' does not contain a definition for 'HasErrors' and no accessible extension method 'HasErrors' accepting a first argument of type 'EvaluationResults' could be found (are you missing a using directive or an assembly reference?) [/home/runner/work/Aspire/Aspire/tests/CommunityToolkit.Aspire.Testing/CommunityToolkit.Aspire.Testing.csproj::TargetFramework=net10.0]

---
updated-dependencies:
- dependency-name: JsonSchema.Net
  dependency-version: 9.4.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title Bump JsonSchema.Net from 7.4.0 to 9.4.0 Bump JsonSchema.Net to 9.4.0 Aug 1, 2026
@dependabot
dependabot Bot force-pushed the dependabot/nuget/JsonSchema.Net-9.4.0 branch from 74c970a to ae847da Compare August 1, 2026 20:44
@dependabot
dependabot Bot requested a review from oising as a code owner August 1, 2026 20:44
@afscrome

afscrome commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@copilot Update the branch and fix the breaking change this introduces

Co-authored-by: afscrome <289860+afscrome@users.noreply.github.com>

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@copilot Update the branch and fix the breaking change this introduces

Fixed in the latest commit. The changes in ConformanceTests.cs:

  • Replaced JsonNode.Parse(...) + schema.Evaluate(node) with JsonDocument.Parse(...).RootElement + schema.Evaluate(element) since JsonSchema.Net 9.x changed Evaluate() to accept JsonElement instead of JsonNode
  • Replaced the removed EvaluationResults.HasErrors with x.Errors is not null && x.Errors.Any()
  • Updated using System.Text.Json.Nodesusing System.Text.Json accordingly

The project now builds successfully.

Copilot AI requested a review from afscrome August 1, 2026 22:23

<ItemGroup>
<PackageReference Include="Aspire.Hosting" />
<PackageReference Include="JsonSchema.Net" VersionOverride="9.4.0" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Why was this added? Including a version here outside of Directory.Packages.props feels like a rake waiting to be stepped on.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added erroneously by dependabot — the PowerShell project doesn't use JsonSchema.Net anywhere in code, so there was no reason for it to be there. Removed in the latest commit.

Co-authored-by: afscrome <289860+afscrome@users.noreply.github.com>
Copilot AI requested a review from afscrome August 1, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file skip-nuget-publish Skips publishing to NuGet when merging to the `main` branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants