N°6863 - Allow mail inbox administrator to choose log attribute in which updates will be added

[Molkobain]

Objective
Allow mail inbox administrator to choose log attribute in which updates will be added

Use case

• 1 mail inbox for caller creation / updates in the public log
• 1 mail inbox for provider (dispatched) updates in another log

The idea is to avoid the end-user to be aware of the provider updates

Proposed solution

• De-hardcoded the target log attribute and display it in the mail inbox object
• Set default value to "public_log" for backward compatibility
• Use of an AttributeString instead of an ÀttributeClassAttCodeSet` to avoid data migration and as default value is not handled well, but this can be subject to discussion.

Appendices
XML snippet for AttributeClassAttCodeSet:

<field id="ticket_updates_log_attcode" xsi:type="AttributeClassAttCodeSet">
  <sql>ticket_updates_log_attcode</sql>
  <class_field>target_class</class_field>
  <attribute_definition_list>AttributeCaseLog</attribute_definition_list>
  <min_items>1</min_items>
  <max_items>1</max_items>
  <default_value>public_log</default_value>
  <is_null_allowed>false</is_null_allowed>
  <dependencies>
    <attribute id="target_class" />
  </dependencies>
</field>

[Hipska]

Could you also elaborate what the exact issue is with AttributeClassAttCodeSet? Doesn't it fill in the default value in the database on creation of the column?

[Hipska]

$sAttCode will get overwritten by this default module setting..

Should this setting be obsoleted and ignored maybe?

[Molkobain]

You are right, I'll fix it!

[Molkobain]

I just changed the conf. param. default value to an empty array; but actually the whole conf. param. should be obsoleted you are right.

[Hipska]

What about existing/upgrading users? They will still have the setting from previous install. Also new users will have this setting as it is still present in module file.

[Molkobain]

That's why obsoleting the param. and removing the line from the code is the best way IMHO.

For existing users, we should check the existing conf. param. and apply the corresponding value to existing mail inboxes. I missed that!

[Hipska]

That could be an action during setup (after database creation) for example..

[Molkobain]

Totally

[Molkobain]

Could you also elaborate what the exact issue is with AttributeClassAttCodeSet? Doesn't it fill in the default value in the database on creation of the column?

I wasn't able to prefill the attribute with a default value when creating a new mail inbox, even with public_log or |public_log| as default value in the XML.

[Hipska]

I wasn't able to prefill the attribute with a default value when creating a new mail inbox, even with public_log or |public_log| as default value in the XML.

You found a bug? 😁

[Molkobain]

You found a bug? 😁

Let's call it a known limitation 😅😭