Skip to content

N°8162 - Issue when synchronizing datasource with read-only notify_contact_id_archive_flag#56

Open
odain-cbd wants to merge 10 commits intomasterfrom
feature/8162-synchro-issue
Open

N°8162 - Issue when synchronizing datasource with read-only notify_contact_id_archive_flag#56
odain-cbd wants to merge 10 commits intomasterfrom
feature/8162-synchro-issue

Conversation

@odain-cbd
Copy link
Copy Markdown
Contributor

Purpose

Current PR aims at gathering all special attributes at the same place. These attributes should not be taken into account to deal with datasource computation/synchronization.

Symptom

Datasource synchronization may fail with below error due to a regression (PR 32/ N°6115):
[Error] Failed to update the SynchroDataSource 'XXX' (2). Reason: Error: notify_contact_id_archive_flag: Attempting to set the value on the read-only attribute SynchroDataSource::notify_contact_id_archive_flag (100)

Corollary

Datasource computation has been enhanced and related test coverage completed...

@odain-cbd odain-cbd added bug Something isn't working enhancement New feature or request labels Feb 5, 2025
@odain-cbd odain-cbd self-assigned this Feb 5, 2025
@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Feb 5, 2025
Comment thread core/collector.class.inc.php Outdated
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
@rquetiez rquetiez self-requested a review July 10, 2025 08:21
Comment thread core/collector.class.inc.php
Comment thread core/collector.class.inc.php Outdated
Comment thread test/collector/attribute_isnullified/iTopPersonCollector.class.inc.php Outdated
@odain-cbd odain-cbd requested review from Hipska and accognet March 16, 2026 14:03
Comment thread core/collector.class.inc.php Outdated
@odain-cbd odain-cbd requested a review from Hipska March 17, 2026 06:51
Copy link
Copy Markdown
Collaborator

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I said

Same for all other occurrences of course.

Please also resolve the conflicts, so that can be reviewed as well 😉

Comment thread core/collector.class.inc.php Outdated
Comment thread core/collector.class.inc.php Outdated
Comment thread core/collector.class.inc.php Outdated
@odain-cbd odain-cbd requested a review from Hipska March 27, 2026 16:53
Copy link
Copy Markdown
Collaborator

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts, so that it can be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants