JsonCollector: Introduce GetOptionalHeaders() and GetCurlOptions() methods#44
Open
jbostoen wants to merge 8 commits intoCombodo:masterfrom
Open
JsonCollector: Introduce GetOptionalHeaders() and GetCurlOptions() methods#44jbostoen wants to merge 8 commits intoCombodo:masterfrom
jbostoen wants to merge 8 commits intoCombodo:masterfrom
Conversation
Molkobain
requested changes
Jan 16, 2024
Hipska
suggested changes
Jan 17, 2024
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Molkobain
reviewed
Jan 18, 2024
Hipska
reviewed
Jan 18, 2024
Hipska
approved these changes
Jan 18, 2024
Contributor
|
I come after all other feedbacks. everything is ok to me. great job and idea! NB: |
odain-cbd
approved these changes
Jan 22, 2024
Molkobain
approved these changes
Feb 6, 2024
Contributor
|
Technical review:
|
Contributor
|
Note: Maybe we should use \CallItopService::CallItopViaHttp() instead and adjust the factorisation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to make it easier to extend the JsonCollector.
Use case: A third-party API which requires Basic Authorization with each POST request.
Basic Authorization can basically be performed in these ways:
CURLOPT_USERPWD.Without the PR:
WIth the PR:
By default, no HTTP headers are set.
By default, cURL options = cURL options as defined in the "conf" XML (as before); and cURL options as defined in the "collectors" XML (these are superseding).
Note: I used the correct spelling of "optional". In the source code, it's consistently written incorrectly with "optionnal". I was considering updating it, but that might cause issues if people already extended classes and if those methods were overridden.