Skip to content

[Enhance] Make function reporter parameters nullable #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Real-MullaC merged 1 commit into from
Jul 4, 2026
Merged

[Enhance] Make function reporter parameters nullable #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions MicroWin/functions/iso/IsoManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private string BuildIsoObjectPath(string isoPath)
return String.Format("MSFT_DiskImage.ImagePath={0},StorageType=1", $"\"{isoPath.Replace("\\", "\\\\")}\"");
}

public void ExtractIso(string? driveLetter, string destination, Action<int> progressCallback, Action<string> fileProgressCallback)
public void ExtractIso(string? driveLetter, string destination, Action<int>? progressCallback = null, Action<string>? fileProgressCallback = null)
{
string source = $"{driveLetter}:\\";
DynaLog.logMessage($"Starting extraction from {source} to {destination}");
Expand Down Expand Up @@ -124,13 +124,13 @@ public void ExtractIso(string? driveLetter, string destination, Action<int> prog
string? destDir = Path.GetDirectoryName(destFile);
if (!Directory.Exists(destDir)) Directory.CreateDirectory(destDir ?? "");

fileProgressCallback.Invoke(file);
if (fileProgressCallback is not null) fileProgressCallback.Invoke(file);

File.Copy(file, destFile, true);
copiedFiles++;

int percentage = (int)((double)copiedFiles / files.Length * 100);
progressCallback?.Invoke(percentage);
if (progressCallback is not null) progressCallback.Invoke(percentage);
}
catch (Exception ex)
{
Expand Down
Loading