-
-
Notifications
You must be signed in to change notification settings - Fork 398
West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 3 | Sprint 3 TDD Coursework #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
282f847
9e54083
8105e55
ba00f54
3c9c8d1
57a4735
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| const lengthOfStr = stringOfCharacters.length; | ||
| let numOfOccurrence = 0; | ||
| for(let i = 0; i< lengthOfStr ; i++){ | ||
| if(stringOfCharacters[i] == findCharacter){ | ||
| numOfOccurrence = numOfOccurrence + 1; | ||
| } | ||
| } | ||
| return numOfOccurrence; | ||
| } | ||
|
|
||
| module.exports = countChar; |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the updated version directly using number for processing, the p.s.: in the future, please label it as "Needs review" (and remove "Reviewed") for re-review. Otherwise the system will not show up your PR after your fixes. Thank you.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi! I understand now. I've updated the comparisons to use numbers and ===, Thank you! |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,21 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| let getStr = num.toString(); | ||
| let lastTwoDigit = getStr.slice(-2); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. while this line works even when the string only contains a single digit, it would be hard to maintain in a more complex project. |
||
| let lastDigit = getStr.slice(-1); | ||
| if(lastTwoDigit == "11" || lastTwoDigit == "12" || lastTwoDigit == "13"){ | ||
| return getStr + "th"; | ||
| } | ||
| else if(lastDigit =="1"){ | ||
| return getStr + "st"; | ||
| } | ||
| else if(lastDigit == "2"){ | ||
| return getStr + "nd"; | ||
| } | ||
| else if(lastDigit == "3"){ | ||
| return getStr + "rd"; | ||
| } | ||
| else{ | ||
| return getStr + "th"; | ||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no test case for the |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please tidy-up the indentation so that it would be easier to read. It is also a good and important practice as well. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,17 @@ | ||
| function repeatStr() { | ||
| function repeatStr(str, count) { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| let result=""; | ||
| if (count >=1){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why this |
||
| for(let i=1 ; i <= count ; i++){ | ||
| result= str + result; | ||
| } | ||
| return result; | ||
| } | ||
| else if (count == 0){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why this |
||
| return ""; | ||
| } | ||
| throw new Error("invalid count") | ||
| } | ||
|
|
||
| module.exports = repeatStr; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about empty string (with the same set of |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,34 @@ | ||
| // Implement a function repeatStr | ||
| const repeatStr = require("./repeat-str"); | ||
| // Given a target string `str` and a positive integer `count`, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should: | ||
|
|
||
| // Case: handle multiple repetitions: | ||
| // Given a target string `str` and a positive integer `count` greater than 1, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return a string that contains the original `str` repeated `count` times. | ||
|
|
||
| // Case: handle multiple repetitions | ||
| test("should repeat the string count times", () => { | ||
| const str = "hello"; | ||
| const count = 3; | ||
| const repeatedStr = repeatStr(str, count); | ||
| expect(repeatedStr).toEqual("hellohellohello"); | ||
| }); | ||
|
|
||
| // Case: handle count of 1: | ||
| // Given a target string `str` and a `count` equal to 1, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return the original `str` without repetition. | ||
| // Case: handle count of 1 | ||
| test("should return the original string when count is 1", () => { | ||
| const str = "Maryam"; | ||
| const count = 1; | ||
| const repeatedStr = repeatStr(str, count); | ||
| expect(repeatedStr).toEqual(str); | ||
| }); | ||
|
|
||
| // Case: handle count of 0 | ||
| test("should return an empty string when count is 0", () => { | ||
| const str = "Hello World!"; | ||
| const count = 0; | ||
| const repeatedStr = repeatStr(str, count); | ||
| expect(repeatedStr).toEqual(""); | ||
| }); | ||
|
|
||
| // Case: Handle count of 0: | ||
| // Given a target string `str` and a `count` equal to 0, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return an empty string. | ||
| // Case: handle negative count | ||
| test("should throw an error when count is negative", () => { | ||
| const str = "Hello World!"; | ||
| const count = -1; | ||
|
|
||
| // Case: Handle negative count: | ||
| // Given a target string `str` and a negative integer `count`, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should throw an error, as negative counts are not valid. | ||
| expect(() => repeatStr(str, count)).toThrow(); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The given example of
aaaaais a special case. There should be more general cases for multiple occurences.Also, there is one more boundary case for no occurrences. Can you think of it?