Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
const lengthOfStr = stringOfCharacters.length;
let numOfOccurrence = 0;
for(let i = 0; i< lengthOfStr ; i++){
if(stringOfCharacters[i] == findCharacter){
numOfOccurrence = numOfOccurrence + 1;
}
}
return numOfOccurrence;
}

module.exports = countChar;
6 changes: 6 additions & 0 deletions Sprint-3/2-practice-tdd/count.test.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The given example of aaaaa is a special case. There should be more general cases for multiple occurences.

Also, there is one more boundary case for no occurrences. Can you think of it?

Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => {
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.
test("should return 0 when the character does not exist in the string", () => {
const str = "Hello world";
const char = "a";
const count = countChar(str, char);
expect(count).toEqual(0);
});
20 changes: 18 additions & 2 deletions Sprint-3/2-practice-tdd/get-ordinal-number.js

@hackertainment hackertainment Aug 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the updated version directly using number for processing, the if and else if would better be using number comparison as well. Especially when you use === instead of ==, you will see what I meant.

p.s.: in the future, please label it as "Needs review" (and remove "Reviewed") for re-review. Otherwise the system will not show up your PR after your fixes. Thank you.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I understand now. I've updated the comparisons to use numbers and ===, Thank you!

Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
function getOrdinalNumber(num) {
return "1st";
let getStr = num.toString();
let lastTwoDigit = getStr.slice(-2);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this line works even when the string only contains a single digit, it would be hard to maintain in a more complex project.

let lastDigit = getStr.slice(-1);
if(lastTwoDigit == "11" || lastTwoDigit == "12" || lastTwoDigit == "13"){
return getStr + "th";
}
else if(lastDigit =="1"){
return getStr + "st";
}
else if(lastDigit == "2"){
return getStr + "nd";
}
else if(lastDigit == "3"){
return getStr + "rd";
}
else{
return getStr + "th";
}
}

module.exports = getOrdinalNumber;
18 changes: 18 additions & 0 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test case for the lastTwoDigit part of your function. Please add them back. Thanks.

Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,21 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});

test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(22)).toEqual("22nd");
expect(getOrdinalNumber(42)).toEqual("42nd");
expect(getOrdinalNumber(102)).toEqual("102nd");
});
test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(23)).toEqual("23rd");
expect(getOrdinalNumber(103)).toEqual("103rd");
});
test("should append 'th' for numbers", () => {
expect(getOrdinalNumber(4)).toEqual("4th");
expect(getOrdinalNumber(10)).toEqual("10th");
expect(getOrdinalNumber(13)).toEqual("13th");
expect(getOrdinalNumber(100)).toEqual("100th");
});
14 changes: 12 additions & 2 deletions Sprint-3/2-practice-tdd/repeat-str.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tidy-up the indentation so that it would be easier to read. It is also a good and important practice as well.

Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
function repeatStr() {
function repeatStr(str, count) {
// Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat).
// The goal is to re-implement that function, not to use it.
return "hellohellohello";
let result="";
if (count >=1){

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this if is needed?

for(let i=1 ; i <= count ; i++){
result= str + result;
}
return result;
}
else if (count == 0){

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this else if is needed?

return "";
}
throw new Error("invalid count")
}

module.exports = repeatStr;
42 changes: 22 additions & 20 deletions Sprint-3/2-practice-tdd/repeat-str.test.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about empty string (with the same set of counts 3, 1, 0, -1)?

Original file line number Diff line number Diff line change
@@ -1,32 +1,34 @@
// Implement a function repeatStr
const repeatStr = require("./repeat-str");
// Given a target string `str` and a positive integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should:

// Case: handle multiple repetitions:
// Given a target string `str` and a positive integer `count` greater than 1,
// When the repeatStr function is called with these inputs,
// Then it should return a string that contains the original `str` repeated `count` times.

// Case: handle multiple repetitions
test("should repeat the string count times", () => {
const str = "hello";
const count = 3;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("hellohellohello");
});

// Case: handle count of 1:
// Given a target string `str` and a `count` equal to 1,
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.
// Case: handle count of 1
test("should return the original string when count is 1", () => {
const str = "Maryam";
const count = 1;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual(str);
});

// Case: handle count of 0
test("should return an empty string when count is 0", () => {
const str = "Hello World!";
const count = 0;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("");
});

// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.
// Case: handle negative count
test("should throw an error when count is negative", () => {
const str = "Hello World!";
const count = -1;

// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.
expect(() => repeatStr(str, count)).toThrow();
});
Loading