-
-
Notifications
You must be signed in to change notification settings - Fork 500
London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ebrahim-Moqbel
wants to merge
29
commits into
CodeYourFuture:main
Choose a base branch
from
Ebrahim-Moqbel:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
106549d
Git difinition and purpose
Ebrahim-Moqbel 08737b5
Git difinition and purpose
Ebrahim-Moqbel 9e2e03c
content of the page
Ebrahim-Moqbel 9f59b69
Merge branch 'feature/wireframe' of https://github.com/Ebrahim-Moqbel…
Ebrahim-Moqbel 8eb31fa
113fdc5
commit
Ebrahim-Moqbel 34db322
Merge branch 'CodeYourFuture:main' into feature/wireframe
Ebrahim-Moqbel b2b717c
Delete unnecessary readme file
Ebrahim-Moqbel 2e9e44a
Add files via upload
Ebrahim-Moqbel 52684f7
Add files via upload
Ebrahim-Moqbel ef60105
.
Ebrahim-Moqbel 7ec9964
Add files via upload
Ebrahim-Moqbel 7df260f
images added
Ebrahim-Moqbel 17bcf82
css modified
Ebrahim-Moqbel 9859e3a
centre the footer
Ebrahim-Moqbel 4fe0370
fixed the footer
Ebrahim-Moqbel fafcdd9
changes in the header
Ebrahim-Moqbel a76cd4e
changes in the header
Ebrahim-Moqbel 490a6e3
changes to CSS
Ebrahim-Moqbel b5ce99a
deleted unwanted images from the source file
Ebrahim-Moqbel 3c545a6
changed imges to be in an img file
Ebrahim-Moqbel 64dd101
made changes to the css file
Ebrahim-Moqbel 48b9f84
changed the article tag fromheader from
Ebrahim-Moqbel 1a09438
Update alt text for images in index.html
Ebrahim-Moqbel 1c81560
Add target='_blank' to external links in index.html
Ebrahim-Moqbel c8c7098
Add meta description to index.html
Ebrahim-Moqbel 1b86361
Merge branch 'main' into feature/wireframe
Ebrahim-Moqbel e1dc8cf
Rename footer class to match HTML structure
Ebrahim-Moqbel 2c397b4
Remove class attribute from footer element
Ebrahim-Moqbel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| What is Git and why is it used? | ||
|
|
||
| Git is a version control system used for tracking changes in computer files. It is generally used for source code management in software development. | ||
|
|
||
| Git is used to tracking changes in the source code | ||
| The distributed version control tool is used for source code management | ||
| It allows multiple developers to work together | ||
| It supports non-linear development through its thousands of parallel branches |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,107 @@ | ||
| /* Here are some starter styles | ||
| You can edit these or replace them entirely | ||
| It's showing you a common way to organise CSS | ||
| And includes solutions to common problems | ||
| As well as useful links to learn more */ | ||
|
|
||
| /* ====== Design Palette ====== | ||
| This is our "design palette". | ||
| It sets out the colours, fonts, styles etc to be used in this design | ||
| At work, a designer will give these to you based on the corporate brand, but while you are learning | ||
| You can design it yourself if you like | ||
| Inspect the starter design with Devtools | ||
| Click on the colour swatches to see what is happening | ||
| I've put some useful CSS you won't have learned yet | ||
| For you to explore and play with if you are interested | ||
| https://web.dev/articles/min-max-clamp | ||
| https://scrimba.com/learn-css-variables-c026 | ||
| ====== Design Palette ====== */ | ||
| /* ====== Design Palette ====== */ | ||
| :root { | ||
| --paper: oklch(7 0 0); | ||
| --paper: oklch(97% 0 0); | ||
| --ink: color-mix(in oklab, var(--color) 5%, black); | ||
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| } | ||
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
|
|
||
| /* ====== Base Elements ====== */ | ||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| padding-bottom: 60px; | ||
| margin: 0; | ||
| } | ||
|
|
||
| a { | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| max-width: fit-content; | ||
| display: inline-block; | ||
| padding: 0.5rem 1rem; | ||
| background: #333; | ||
| color: #fff; | ||
| text-decoration: none; | ||
| border-radius: 4px; | ||
| text-align: center; | ||
| margin-top: var(--space); | ||
| } | ||
|
|
||
| a:hover { | ||
| background: #555; | ||
| } | ||
|
|
||
| img, | ||
| svg { | ||
| width: 100%; | ||
| height: 250px; /* Fixed height for all images */ | ||
| object-fit: cover; | ||
| display: block; | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
|
|
||
| /* ====== Header ====== */ | ||
| .header { | ||
| text-align: center; | ||
| padding: calc(var(--space) * 2); | ||
| background-color: #f6f4f4; | ||
| margin-bottom: calc(var(--space) * 2); | ||
| } | ||
|
|
||
| .header h1 { | ||
| margin: 0 0 var(--space) 0; | ||
| } | ||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
| Inspect this in Devtools and click the "grid" button in the Elements view | ||
| Play with the options that come up. | ||
| https://developer.chrome.com/docs/devtools/css/grid | ||
| https://gridbyexample.com/learn/ | ||
| */ | ||
|
|
||
| /* ====== Site Layout ====== */ | ||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: var(--space); | ||
| > *:first-child { | ||
| grid-column: span 2; | ||
| } | ||
| padding: 0 var(--space); | ||
| } | ||
| /* ====== Article Layout ====== | ||
| Setting the rules for how elements are placed in the article. | ||
| Now laying out just the INSIDE of the repeated card/article design. | ||
| Keeping things orderly and separate is the key to good, simple CSS. | ||
| */ | ||
|
|
||
| main > *:first-child { | ||
| grid-column: span 2; | ||
| } | ||
|
|
||
| /* ====== Article Layout ====== */ | ||
| article { | ||
| border: var(--line); | ||
| padding-bottom: var(--space); | ||
| text-align: left; | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| > * { | ||
| grid-column: 2/3; | ||
| } | ||
| > img { | ||
| grid-column: span 3; | ||
| } | ||
| } | ||
|
|
||
| article > * { | ||
| grid-column: 2/3; | ||
| } | ||
|
|
||
| article > img { | ||
| grid-column: span 3; | ||
| margin-bottom: var(--space); | ||
| } | ||
|
|
||
| article h2 { | ||
| margin-top: var(--space); | ||
| } | ||
|
|
||
| /* ====== Footer ====== */ | ||
| .footer { | ||
|
Ebrahim-Moqbel marked this conversation as resolved.
Outdated
|
||
| position: fixed; | ||
| bottom: 0; | ||
| text-align: center; | ||
| height: 60px; | ||
| background-color: #f6f4f4; | ||
| width: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| border-top: var(--line); | ||
| } | ||
|
|
||
| .footer p { | ||
| margin: 0; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.