Skip to content

London | 26-ITP-May | Edina Kurdi | Sprint 3 | Alarm clock #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edinakurdi wants to merge 10 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-May | Edina Kurdi | Sprint 3 | Alarm clock #1430

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
13bf268
add title to html
edinakurdi Aug 13, 2026
d22745d
start implementing setAlarm()
edinakurdi Aug 13, 2026
e667709
start implementing setAlarm() function
edinakurdi Aug 13, 2026
1751d49
start countdown
edinakurdi Aug 13, 2026
45dfc50
set a stopping point
edinakurdi Aug 13, 2026
57d6de0
delete unused code
edinakurdi Aug 14, 2026
efd9c41
add validation for user input to account for decimals and negative nu…
edinakurdi Aug 14, 2026
2e32afc
implement time conversion function to be re-used in the function
edinakurdi Aug 14, 2026
5893a8c
reset actibe timer and audio before a new countdown
edinakurdi Aug 14, 2026
3fcc665
reset input box after a timer starts
edinakurdi Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,25 @@
function setAlarm() {}
function setAlarm() {
const timeInput = document.getElementById("alarmSet");
// console.log(timeInput.value);
let remainingSeconds = timeInput.value;

@cjyuan cjyuan Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Using raw input without proper validation is a dangerous practice. For number, we should consider

    • What type of number should it be? Integer or floating point number?
    • What range of numbers are acceptable?
    • What kind of invalid value should also be rejected?

  • Unused code and comments should be removed to keep the code clean.

@edinakurdi edinakurdi Aug 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out.
Code is updated accordingly.


const timeRemaining = document.getElementById("timeRemaining");
const minutes = String(Math.floor(remainingSeconds / 60)).padStart(2, "0");
const seconds = String(remainingSeconds - minutes * 60).padStart(2, "0");

timeRemaining.textContent = `Time Remaining: ${minutes}:${seconds}`;

const timer = setInterval(() => {
remainingSeconds--;
const minutes = String(Math.floor(remainingSeconds / 60)).padStart(2, "0");
const seconds = String(remainingSeconds - minutes * 60).padStart(2, "0");
timeRemaining.textContent = `Time Remaining: ${minutes}:${seconds}`;

@cjyuan cjyuan Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code on lines 7-10 is very similar to those on lines 14-16.
To adhere to the DRY principle in programming, could you refactor the repeated code into a reusable function?

@edinakurdi edinakurdi Aug 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

if (remainingSeconds === 0) {
playAlarm();
clearInterval(timer);
}
}, 1000);
}

// DO NOT EDIT BELOW HERE

Expand Down
37 changes: 20 additions & 17 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
</head>
<body>
<div class="centre">
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />

<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
</div>
<script src="alarmclock.js"></script>
</body>
</html>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Alarm clock app</title>
</head>

<body>
<div class="centre">
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />

<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
</div>
<script src="alarmclock.js"></script>
</body>

</html>
Loading