Skip to content

London | 26-ITP-May | Gideon Defar | Sprint 3 | Alarm Clock App #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gideondefar wants to merge 5 commits into
base: main
Choose a base branch
from
+38 −3
Open

London | 26-ITP-May | Gideon Defar | Sprint 3 | Alarm Clock App #1423

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f753da
Update page title to Alarm clock app
Aug 12, 2026
3eb88fc
Implement alarm clock countdown
Aug 12, 2026
2bc64b2
Validate alarm input before clearing timer
Aug 12, 2026
038cbf9
Simplify alarm input validation
Aug 12, 2026
044d0d5
Use const for non-reassigned variables
Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,40 @@
function setAlarm() {}
let timer;

function updateDisplay(time) {

let heading = document.getElementById("timeRemaining");

@selyafi selyafi Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these three are ever reassigned. What's your rule for picking between let and const?

@gideondefar gideondefar Aug 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! ooh I see you are right. I use let basically to reassign the variable later but const is for fixed or constant variables.

let minutes = Math.floor(time / 60);
let seconds = time % 60;

heading.innerText =
"Time Remaining: " +
String(minutes).padStart(2, "0") +
":" +
String(seconds).padStart(2, "0");
}

function setAlarm() {

if (timer) clearInterval(timer);

@selyafi selyafi Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the browser, start a 10-second countdown, then clear the input box and click Set Alarm again. What happens to the countdown, and is that what a user would expect? Have a look at the order of this line and line 23.

@gideondefar gideondefar Aug 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it keeps countdown to 0.

audio.pause();
audio.currentTime = 0;

let time = Number(document.getElementById("alarmSet").value);
if (isNaN(time) || !Number.isInteger(time) || time <= 0) return;

@selyafi selyafi Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run Number.isInteger(NaN) into your browser console and what comes back? Is the isNaN(time) check earning its place here?

@gideondefar gideondefar Aug 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, It's kind of redundant, So I removed it. !Number.isInteger(time) already checks the condition.


updateDisplay(time);

timer = setInterval(function () {
time = time - 1;

updateDisplay(time);

if (time <= 0) {
playAlarm();
clearInterval(timer);
}
}, 1000);
}

// DO NOT EDIT BELOW HERE

Expand All @@ -22,4 +58,4 @@ function pauseAlarm() {
audio.pause();
}

window.onload = setup;
window.onload = setup;
2 changes: 1 addition & 1 deletion Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
Expand Down
Loading