Skip to content

London | 26-ITP-May | Edina Kurdi | Sprint 2 | Coursework - #1422

Open
edinakurdi wants to merge 26 commits into
CodeYourFuture:mainfrom
edinakurdi:coursework/sprint-2
Open

London | 26-ITP-May | Edina Kurdi | Sprint 2 | Coursework#1422
edinakurdi wants to merge 26 commits into
CodeYourFuture:mainfrom
edinakurdi:coursework/sprint-2

Conversation

@edinakurdi

@edinakurdi edinakurdi commented Aug 11, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Data Groups - Sprint 2

  • debug
    • Address
    • Author
    • Recipe
  • implement
    • contains + test
    • lookup + test
    • querystring + test
    • tally + test
  • interpret
    • invert + test

@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@edinakurdi edinakurdi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Aug 11, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 12, 2026
Comment thread Sprint-2/debug/author.js
Comment on lines +20 to +23
console.log(Object.values(author));
// for (const value of author) {
// console.log(value);
// }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good workaround to print the values of the object.

Question - how could the for loop on lines 21 - 23 be changed (to a different loop for example) to achieve the same effect?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an alternative using a loop

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor- I was also thinking of a for in loop, if we changed line 21 to a for in you'd have a direct way of printing the values in a readable way

for (const key in author){
console.log(author[key])
}

Comment thread Sprint-2/debug/recipe.js Outdated
Comment thread Sprint-2/implement/contains.js Outdated
Comment thread Sprint-2/implement/lookup.test.js
Comment thread Sprint-2/implement/contains.test.js Outdated
Comment thread Sprint-2/implement/tally.js Outdated
Comment thread Sprint-2/implement/tally.js Outdated
Comment thread Sprint-2/implement/querystring.js Outdated

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, slight amendments/refactors or explanations needed - take a look, nice work here though, good use of methods and testing throughout

@Poonam-raj Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 12, 2026
@edinakurdi edinakurdi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 13, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 17, 2026
expect(tally(["a", "a", "a"])).toEqual({ a: 3 });
});
});
describe("when given an array with duplicate items", () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid having two describe blocks with the same text (this is the same as line 31)

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - I spotted one describe block that needs correcting but other than that it looks great - thanks for all the corrections

@Poonam-raj Poonam-raj added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants