London | 26-ITP-May | Jorvan White | Sprint 2 | Coursework - #1418
Open
JorvanW wants to merge 26 commits into
Open
London | 26-ITP-May | Jorvan White | Sprint 2 | Coursework #1418JorvanW wants to merge 26 commits into
JorvanW wants to merge 26 commits into
Conversation
added 14 commits
July 20, 2026 19:32
This comment has been minimized.
This comment has been minimized.
JorvanW
changed the title
This comment has been minimized.
This comment has been minimized.
JorvanW
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
JorvanW
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
JorvanW
added
the
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Aug 11, 2026
Poonam-raj
reviewed
Aug 11, 2026
Comment on lines
+1
to
+20
| function tally(array) { //(array) is the input to the function | ||
|
|
||
| if (!Array.isArray(array)){ //checking if array is actually an array | ||
| throw new Error("Input must be an array"); | ||
| } | ||
|
|
||
| if (array.length === 0){ //if array is empty return a empty array | ||
| return [] | ||
| } | ||
|
|
||
|
|
||
| const result = {} //creates result as an empty object which will store the counts | ||
|
|
||
|
|
||
| for (const item of array){ //'for' loops through every item in the array | ||
| if (result[item]){ // checks if the item is already in the result{} | ||
| result[item]++} // If it is then '++' tells it to add 1 to the value | ||
|
|
||
| else { | ||
| result[item] = 1; // else is saying that if it doesn't exist then we give it a value of 1 |
There was a problem hiding this comment.
I generally appreciate the comments adding clarity for future ref and readers, but it's not needed and maybe makes the committed code messy. This solution is fairly easy to interpret without it and we want clean commits as much as possible
There was a problem hiding this comment.
this did not remove comments - please remove unnecesary comments
Poonam-raj
reviewed
Aug 11, 2026
Poonam-raj
reviewed
Aug 11, 2026
Poonam-raj
reviewed
Aug 11, 2026
Poonam-raj
reviewed
Aug 11, 2026
Poonam-raj
reviewed
Aug 11, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
Some great work writing tests and implementing solutions - a few comments worth addressing, especially in the interpret section where testing is particularly lacking
Poonam-raj
added
Reviewed
added 6 commits
August 13, 2026 09:44
…object as required
…test cases for invert
JorvanW
added
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Aug 17, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
Small remaining bits here - good work making corrections. I did leave some comments about test cases which you did not address in the implement section (particularly lookup), can you look at that and my other remainign comments - thanks!
Poonam-raj
added
Reviewed
Author
|
I think github is down (at this time of writing) and there's some syncing issues but on my end the comments from the tally is gone and I currently can't load any of the comments you've made previously. |
|
Hi @JorvanW try again- github should be resolved |
Author
|
updated test cases for invert and lookup |
JorvanW
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Created Pull Request from Sprint 2 Coursework and updated for Pull Request