Skip to content

London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Alarm Clock #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
risikatpopoola wants to merge 6 commits into
base: main
Choose a base branch
from
+65 −3
Open

London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Alarm Clock #1357

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
30f9803
alarm clock app done
risikatpopoola Aug 1, 2026
0161e64
title updated
risikatpopoola Aug 1, 2026
a296952
input box cleared after set alarm runs
risikatpopoola Aug 13, 2026
3a14a0e
input validation for extreme values and non integers
risikatpopoola Aug 13, 2026
33c4e01
Returned to a clean state always and fixed invalid numbers
risikatpopoola Aug 15, 2026
383b8bf
one second delay fixed
risikatpopoola Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,49 @@
function setAlarm() {}
// ## How the clock should work

// When you click the `Set Alarm` button the counter at the top of the screen should change to the number you entered in the `input` field. For example, if the `input` field says `10` then the title should say `Time Remaining: 00:10`.

// Every one second the title should count down by one.

// When the `Time Remaining` reaches `00:00` the alarm should play a sound. You can make the sound happen by using `playAlarm()`.

// You can stop the alarm sound by pressing the `Stop Alarm` button.
const alarmInput = document.querySelector("#alarmSet");
const timeRemaining = document.querySelector("#timeRemaining");

let timer;
function setAlarm() {
clearInterval(timer);
pauseAlarm();
let totalSeconds = Math.round(Number(alarmInput.value));

if (totalSeconds > 36000) {
alert("Please enter a time less than 10 hours.");
updateTime(0);
return;
}
if (alarmInput.value === "" || totalSeconds < 0 || !Number.isInteger(0)) {

@cjyuan cjyuan Aug 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The 3rd condition is always false even if totalSeconds is NaN.

alert("Please enter a valid positive time.");
updateTime(0);
return;
}
alarmInput.value = "";
updateTime(totalSeconds);

timer = setInterval(() => {
if (totalSeconds <= 0) {
clearInterval(timer);
playAlarm();
}
updateTime(totalSeconds--);
}, 1000);
Comment on lines +39 to 47

@cjyuan cjyuan Aug 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, there will always be a one second delay before the alarm sound.
Could you find a way to get rid the one second delay?

@risikatpopoola risikatpopoola Aug 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I Have fixed this now. THank you

}

function updateTime(secs) {
const minutes = String(Math.floor(secs / 60)).padStart(2, "0");
const seconds = String(secs % 60).padStart(2, "0");

timeRemaining.innerText = `Time Remaining: ${minutes}:${seconds}`;
}
// DO NOT EDIT BELOW HERE

var audio = new Audio("alarmsound.mp3");
Expand Down
4 changes: 2 additions & 2 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm Clock app</title>
</head>
<body>
<div class="centre">
Expand Down
9 changes: 9 additions & 0 deletions Sprint-3/alarmclock/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,13 @@

h1 {
text-align: center;
color: rgb(117, 13, 13);
}
body {
background-color: rgb(197, 107, 122);
}
button {
background-color: rgb(151, 77, 114);
color: white;
padding: 10px;
}
Loading