Feat/e2e and unit test suite - #1230
Merged
Merged
Conversation
Cover sendWelcome, sendVerificationComplete, and sendRiskAlert methods with assertions on subject, recipient, and HTML template payloads. Test transport configuration (port 465 secure, incomplete config skip), user-not-found early returns, empty flags handling, and error propagation from the SMTP transport back to callers. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Cover logActivity (create + save), findActivities with all filter paths (userId, actionType, startDate, endDate, combined date range), pagination defaults (page=1, limit=10) and custom sort parameters. Also test findActivitiesByUserId and findActivitiesByActionType with both populated and empty result cases. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…cator HealthController tests mock TerminusModule indicators and assert status 'ok' when healthy and status 'error' when a dependency is down. RedisHealthIndicator tests cover the happy path (connect + ping + quit returns status 'up'), the connection-error path (throws HealthCheckError with status 'down' and error message), quit-after-failure cleanup, password passthrough, and fallback config defaults. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Replace the placeholder spec with comprehensive E2E tests that boot the full NestJS app against real Postgres and Redis. External services (Stellar, Mail, Queue) are mocked to avoid network calls. Covered journeys: - Auth flow: register, login, duplicate-email rejection, wrong-password - Document journey: upload → list → get → risk-assessment → verify, plus duplicate-hash idempotency - Authorization: cross-user document isolation (403), user-scoped document/dispute lists, unauthenticated rejection (401), regular user blocked from admin access-logs (403) - Public verification: unknown-hash returns verified:false, invalid format rejected with 400 - Health check: endpoint responds with status object Tables are truncated between tests for isolation. CI env vars updated to include all required ConfigModule values and --passWithNoTests removed. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
|
@ustaxs is attempting to deploy a commit to the Mftee's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ustaxs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
mftee
requested changes
Aug 26, 2026
mftee
left a comment
mftee
left a comment
Contributor
There was a problem hiding this comment.
@ustaxs This PR currently has a merge conflict with the main branch (mergeable_state: dirty), so it can't be merged as-is. Could you please rebase or merge main into your branch and resolve the conflicting files? Requesting changes until this is resolved.
mftee
approved these changes
Aug 26, 2026
mftee
left a comment
mftee
left a comment
Contributor
There was a problem hiding this comment.
Conflict has been resolved and the branch is clean against main now. The e2e and unit test suite looks solid - approving.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #986
Closes #1115
Closes #1116
Closes #1117