Skip to content

Restrict challenge management GET endpoints to hosts/creators #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Youssef-SH wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restrict challenge management GET endpoints to hosts/creators #5006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions apps/challenges/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,14 @@ def challenge_detail(request, challenge_host_team_pk, challenge_pk):
return Response(response_data, status=status.HTTP_406_NOT_ACCEPTABLE)

if request.method == "GET":
if not (
request.user.id == challenge.creator.created_by.id
or is_user_a_host_of_challenge(request.user, challenge.id)
):
response_data = {
"error": "You are not authorized to make this request"
}
return Response(response_data, status=status.HTTP_403_FORBIDDEN)
serializer = ChallengeSerializer(
challenge, context={"request": request}
)
Expand Down Expand Up @@ -5006,6 +5014,14 @@ def update_allowed_email_ids(request, challenge_pk, phase_pk):
return Response(response_data, status=status.HTTP_400_BAD_REQUEST)

if request.method == "GET":
if not (
request.user.id == challenge.creator.created_by.id
or is_user_a_host_of_challenge(request.user, challenge.id)
):
response_data = {
"error": "You are not authorized to make this request"
}
return Response(response_data, status=status.HTTP_403_FORBIDDEN)
serializer = ChallengePhaseCreateSerializer(
challenge_phase, context={"request": request}
)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/challenges/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,13 @@ def test_get_particular_challenge(self):
)
self.assertEqual(response.status_code, status.HTTP_200_OK)

def test_get_particular_challenge_when_user_is_not_host_or_creator(self):
self.client.force_authenticate(user=self.participant_user)
expected = {"error": "You are not authorized to make this request"}
response = self.client.get(self.url, {})
self.assertEqual(response.data, expected)
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)

def test_update_challenge_when_user_is_not_its_creator(self):
# pylint: disable=attribute-defined-outside-init
self.user1 = User.objects.create(
Expand Down Expand Up @@ -6220,6 +6227,22 @@ def test_get_or_update_allowed_email_ids_success(self):
self.assertEqual(response.data, expected)
self.assertEqual(response.status_code, status.HTTP_200_OK)

def test_get_allowed_email_ids_when_user_is_not_host_or_creator(self):
self.url = ( # pylint: disable=attribute-defined-outside-init
reverse_lazy(
"challenges:get_or_update_allowed_email_ids",
kwargs={
"challenge_pk": self.challenge.pk,
"phase_pk": self.challenge_phase.pk,
},
)
)
self.client.force_authenticate(user=self.participant_user)
expected = {"error": "You are not authorized to make this request"}
response = self.client.get(self.url, {}, format="json")
self.assertEqual(response.data, expected)
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)

def test_get_or_update_allowed_email_ids_patch_success(self):
self.url = ( # pylint: disable=attribute-defined-outside-init
reverse_lazy(
Expand Down