Add workflow invariant test to reject submissions for inactive challenge phases#4984
Open
Shubham-Chaprana wants to merge 2 commits into
Open
Add workflow invariant test to reject submissions for inactive challenge phases#4984Shubham-Chaprana wants to merge 2 commits into
Shubham-Chaprana wants to merge 2 commits into
Conversation
Author
|
CI appears to be failing during dependency build (Cython wheel build), before the tests in this PR are run. |
Author
|
I’ve added a follow-up invariant test (unregistered team submissions) building on this workflow test. It’s currently stacked on this PR and will be retargeted if this merges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a workflow test for the submission endpoint to ensure
submissions are rejected when the challenge phase is inactive and that
no Submission object is created in this case.
The test hits the public API, sets up the minimal required domain objects
(challenge, phase, participant team), and verifies the rejection behavior
without relying on internal control flow.
Note
This branch includes a small test-related fix to avoid interactive behavior during CI.
The change is isolated and does not affect production behavior.