System fixes from #904 (excluding /playground)#927
Merged
Conversation
PR #904 (ClickBench Playground, branch playground-wip) bundles a UI overhaul under /playground/ together with a long tail of unrelated per-system fixes that have been validated against live benchmark runs. This commit lifts the per-system changes (everything except the /playground tree) out into a separately reviewable change so the fixes can land without waiting for the playground UI work. Highlights across the 26 systems touched (full per-file diffs preserved from playground-wip @ origin/playground-wip): - firebolt, firebolt-parquet, firebolt-parquet-partitioned: split monolithic benchmark.sh + run.sh into the new install/start/check/stop/load/query/data-size layout. - kinetica/load: mv hits.tsv.gz into the persist dir (a symlink dangles inside the container, so LOAD ... FROM FILE PATHS 'hits.tsv.gz' failed with Not_Found); cap the RAM tier at 9 GB so smaller VMs don't OOM mid-load. - clickhouse-web: install + create.sql tweaks. - druid/load, parseable/{install,load}: load-path fixes. - pinot/benchmark.sh, tidb/benchmark.sh, byconity/benchmark.sh, chdb-dataframe, daft-parquet*, duckdb-dataframe, pandas, polars-dataframe: benchmark.sh updates + drop .preserve-state files for the systems that don't need them. - polars: drop SQL-to-lambda translation, evaluate expressions directly via server.py / updated query. - presto-partitioned, trino*, cedardb*, umbra: start/load fixes. - quickwit, siglens: queries renamed/rewritten (queries.spl -> queries.sql), README + benchmark.sh aligned. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playground-wip) out of the playground UI overhaul so they can land on their own.playground-wipfor each path; nothing under/playground/is included.Highlights
firebolt,firebolt-parquet,firebolt-parquet-partitioned: split the monolithicbenchmark.sh+run.shinto theinstall/start/check/stop/load/query/data-sizelayout.kinetica/load:mvhits.tsv.gzinto the persist dir (a symlink dangles inside the container, soLOAD ... FROM FILE PATHS 'hits.tsv.gz'failed withNot_Found); cap the RAM tier at 9 GB so smaller VMs don't OOM mid-load.clickhouse-web,druid/load,parseable/{install,load}: load-path fixes.pinot,tidb,byconity,chdb-dataframe,daft-parquet*,duckdb-dataframe,pandas,polars-dataframe:benchmark.shupdates + drop the now-unused.preserve-statefiles.polars: evaluate expressions directly viaserver.py(drops the SQL→lambda translation step).presto-partitioned,trino*,cedardb*,umbra:start/loadfixes.quickwit,siglens: queries renamed/rewritten (queries.spl→queries.sql), README +benchmark.shaligned.Each of these per-system changes has already been validated against live benchmark runs as part of #904; this PR just makes them mergeable independently of the playground UI.
Test plan
system-fixes-from-pr904.Not_Found; trigger a firebolt run and confirm the new per-system scripts produce timings).🤖 Generated with Claude Code