Skip to content

onas_ht_insert: fix issue causing active bckts to be unlinked from ht->head chain #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
val-ms merged 1 commit into from
May 4, 2026
+5 −3
Merged

onas_ht_insert: fix issue causing active bckts to be unlinked from ht->head chain #1712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions clamonacc/inotif/hash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,12 @@ int onas_ht_insert(struct onas_ht *ht, struct onas_element *elem)
int idx = onas_hash(elem->key, elem->klen, ht->size);
struct onas_bucket *bckt = ht->htable[idx];

int ret = 0;
uint32_t bsize = 0;
int ret = 0;
uint32_t bsize = 0;
bool bckt_is_new = false;

if (bckt == NULL) {
bckt_is_new = true;
ht->htable[idx] = onas_bucket_init();
if (ht->htable[idx] == NULL) return CL_EMEM;

Expand All @@ -270,7 +272,7 @@ int onas_ht_insert(struct onas_ht *ht, struct onas_element *elem)
ht->tail = bckt;
bckt->prev = NULL;
bckt->next = NULL;
} else {
} else if (bckt_is_new) { // bckts are never removed from the linked list
struct onas_bucket *ht_tail = ht->tail;
ht_tail->next = bckt;
bckt->prev = ht_tail;
Expand Down
Loading