Fix short writes in scanner temp output paths#1697
Open
val-ms wants to merge 1 commit intoCisco-Talos:mainfrom
Open
Fix short writes in scanner temp output paths#1697val-ms wants to merge 1 commit intoCisco-Talos:mainfrom
val-ms wants to merge 1 commit intoCisco-Talos:mainfrom
Conversation
Contributor
|
|
Fix an EGG comment temp-file bug where the write length used the number of comments instead of the length of the current comment. Also switch raw write paths in scanners.c to cli_writen() so short writes are handled correctly for RAR comments, kept EGG comments, extracted EGG temp files, normalized script output, and UTF-16 HTML temp output. CLAM-2946
val-ms
force-pushed
the
CLAM-2946-egg-parser-issue
branch
from
6bb9a4c to
82b175c
Compare
Contributor
Author
|
I think this is fixed and ready for re-review |
jhumlick
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an EGG comment temp-file bug where the write length used the number of comments instead of the length of the current comment.
Also switch nearby raw write paths in scanners.c to cli_writen() so short writes are handled correctly for RAR comments, extracted EGG temp files, normalized script output, and UTF-16 HTML temp output.
CLAM-2946