Cmake clang tidy #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

val-ms wants to merge 2 commits into Cisco-Talos:main from val-ms:cmake-clang-tidy

Draft

Cmake clang tidy #1492

Clang-tidy: auto-apply changes using readability-braces-around-statem…

GitHub Advanced Security / CodeQL failed May 2, 2025 in 2s

15 new alerts including 12 high severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

12 high
1 medium
2 low

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 245 in libclamav/dsig.c

Code scanning / CodeQL

Exposure of system data to an unauthorized control sphere Medium

This operation exposes system data from

.
This operation exposes system data from

.

Check failure on line 2992 in libclamav/matcher-ac.c

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition High

Comparison between

of type uint16_t and

of wider type int.

Check notice on line 788 in libclamav/mew.c

Code scanning / CodeQL

Pointer overflow check Low

Range check relying on pointer overflow.

Check notice on line 789 in libclamav/mew.c

Code scanning / CodeQL

Pointer overflow check Low

Range check relying on pointer overflow.

Check failure on line 1488 in libclamav/ole2_extract.c

Code scanning / CodeQL

Multiplication result converted to larger type High

Multiplication result may overflow 'int' before it is converted to 'size_t'.

Check failure on line 1898 in libclamav/ole2_extract.c

Code scanning / CodeQL

Multiplication result converted to larger type High

Multiplication result may overflow 'int' before it is converted to 'size_t'.

Check failure on line 1804 in libclamav/others.c

Code scanning / CodeQL

Time-of-check time-of-use filesystem race condition High

The

being operated upon was previously

, but the underlying file may have been changed since then.
The

being operated upon was previously

, but the underlying file may have been changed since then.
The

being operated upon was previously

, but the underlying file may have been changed since then.

Check failure on line 1818 in libclamav/others.c

Code scanning / CodeQL

Time-of-check time-of-use filesystem race condition High

The

being operated upon was previously

, but the underlying file may have been changed since then.

Check failure on line 707 in libclamav/others_common.c

Code scanning / CodeQL

Redundant null check due to previous dereference High

This null check is redundant because

in any case.

Check failure on line 1072 in libclamav/pe_icons.c

Code scanning / CodeQL

Multiplication result converted to larger type High

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.

Check failure on line 1522 in libclamav/pe_icons.c

Code scanning / CodeQL

Multiplication result converted to larger type High

Multiplication result may overflow 'unsigned int' before it is converted to 'size_t'.

Check failure on line 1527 in libclamav/pe_icons.c

Code scanning / CodeQL

Multiplication result converted to larger type High

Multiplication result may overflow 'unsigned int' before it is converted to 'size_t'.

Check failure on line 547 in libclamav/phishcheck.c

Code scanning / CodeQL

Redundant null check due to previous dereference High

This null check is redundant because

in any case.

Check failure on line 432 in libclamav/scanners.c

Code scanning / CodeQL

Time-of-check time-of-use filesystem race condition High

The

being operated upon was previously

, but the underlying file may have been changed since then.

Check failure on line 1928 in libclamav/vba_extract.c

Code scanning / CodeQL

Signed overflow check High

Testing for signed overflow may produce undefined results.

Check failure on line 767 in sigtool/sigtool.c

Code scanning / CodeQL

Time-of-check time-of-use filesystem race condition High

The

being operated upon was previously

, but the underlying file may have been changed since then.