fix(analyzer): cache resolved exclude paths#8062
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
--exclude-pathspatterns once before the analyzer file walk instead of expanding globs for every candidate file..gitignore, file-size checks, and config-file detection in the same lookup set.Related Issue
Closes #8061.
Checklist
I submit this contribution under the Apache-2.0 license.
Verification
go test ./pkg/analyzergit diff --checkAdditional local check:
go test ./pkg/engine/providertimed out locally on Windows after 124s.go test ./pkg/engine/provider -run TestProvider_getExcludePaths -count=1still fails on Windows path expectations unrelated to this patch (test_getExcludedPaths_with_double_startreturns nil for the existing fixture glob).Implemented with Codex assistance; I manually scoped and reviewed the analyzer-only change.