Skip to content

fix(query): allow CloudFormation DB security group /24 CIDRs #8057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omribz156 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

fix(query): allow CloudFormation DB security group /24 CIDRs #8057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/queries/cloudFormation/aws/db_security_group_open_to_large_scope/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ large_scope(ip_address, cidr) {
to_number(input_mask[1]) < 120 # should be 120-128
} else {
input_mask := split(ip_address, "/")
to_number(input_mask[1]) < 25 # should be 25-32
to_number(input_mask[1]) < 24 # should be 24-32
}

exposed_inline_or_standalone_ingress(res, ing_index, type, resource_index) = results { # inline ingresses
Expand Down
3 changes: 2 additions & 1 deletion assets/queries/cloudFormation/aws/db_security_group_open_to_large_scope/test/negative1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@ Resources:
GroupDescription: "Ingress for Amazon EC2 security group"
SecurityGroupIngress:
- CidrIp: 1.2.3.4/28
- CidrIp: 10.0.0.0/24

DbSecurityByEC2SecurityGroup2:
Type: AWS::EC2::SecurityGroup
Properties:
GroupDescription: "Ingress for Amazon EC2 security group"
SecurityGroupIngress:
- CidrIpv6: 2001:db8:a::123/121
- CidrIpv6: 2001:db8:a::123/121
6 changes: 6 additions & 0 deletions assets/queries/cloudFormation/aws/db_security_group_open_to_large_scope/test/negative2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ Resources:
GroupId: !Ref DbSecurityByEC2SecurityGroup1
CidrIp: 1.2.3.4/28

StandaloneIngressIPv4Max256Hosts:
Type: AWS::EC2::SecurityGroupIngress
Properties:
GroupId: !Ref DbSecurityByEC2SecurityGroup1
CidrIp: 10.0.0.0/24

StandaloneIngressIPv6:
Type: AWS::EC2::SecurityGroupIngress
Properties:
Expand Down
Loading