Skip to content

Chunk the calls to ChannelFinder - #119

Merged
jacomago merged 1 commit into
ChannelFinder:masterfrom
jacomago:chunk_cf
Oct 17, 2025
Merged

Chunk the calls to ChannelFinder#119
jacomago merged 1 commit into
ChannelFinder:masterfrom
jacomago:chunk_cf

Conversation

@jacomago

@jacomago jacomago commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

This solves an issue we had here with a 170 000 PV IOC where the ChannelFinder errored out.

@simon-ess simon-ess left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, although the configuration parameter should be documented somewhere.

Also, the tests are failing for some reason.

@tynanford tynanford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the recceiver tests seem flaky. Re-ran the test and the third time was the charm

@mdavidsaver

Copy link
Copy Markdown
Collaborator

Does this change update any minimum version requirements? CF client library? CF service?

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2025

Copy link
Copy Markdown

@jacomago

jacomago commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

Does this change update any minimum version requirements? CF client library? CF service?
Nope. No changes there.

@shroffk

shroffk commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

FYI:
ChannelFinder/ChannelFinderService#187

Adding support on the service side to help address this problem

@jacomago
jacomago requested a review from simon-ess October 16, 2025 13:05
@jacomago
jacomago merged commit e663296 into ChannelFinder:master Oct 17, 2025
36 of 42 checks passed
@jacomago
jacomago deleted the chunk_cf branch October 17, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants