Fix: Resolve transparent UI issue in Copilot Light Mode#2977
Open
taeminlee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the transparent UI issue in Copilot Light Mode. This supersedes #2768, which was auto-closed by the stale bot after 7 days of inactivity and can no longer be reopened. Rebased on the latest
main.The bug is still present in the current release (2.11.1) and on
main.Root cause
The light-mode CSS variables are defined under
#shadow-root-container, but the shadow root element's actual id iscl-shadow-root:So in
libs/copilot/src/index.cssthe base/light variables never match, leaving the Copilot UI transparent in light mode. Dark mode happened to work because it was scoped with a bare.darkselector.Fix
#shadow-root-container→#cl-shadow-rootso light-mode variables actually apply..dark→#cl-shadow-root.dark, and add#cl-shadow-root.light.This is correct because
ThemeProvideradds thelight/darkclass directly onto the shadow root element:Notes
main).Summary by cubic
Fixes the transparent Copilot UI in Light Mode by applying theme CSS variables to the correct shadow root. Updates selectors so light and dark themes render consistently.
#shadow-root-containerto#cl-shadow-rootso light-mode variables apply.#cl-shadow-root.lightand#cl-shadow-root.dark.Written for commit 71e25cb. Summary will update on new commits.