Repository navigation
fix: address #200, #201: Location handling on the Loads page - #205
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
your solution looks good to me! the only thing i'm not seeing when i run it is your note about the override being saved with the session. if i override the location, then return to the loads page, the location seems to reset to the load metadata default. |
@urwahah Oooops, forgot to stage the last changes and commit. Just updated the PR, should be complete now! |
The location (city, climate zone, CA climate region and grid region) can come from the selected load profile or from the optional location search. The two paths behaved differently and could get out of sync. This PR makes the behaviour consistent.
Behaviour
I also added a small one-liner below to the search bar to indicate the current status. See different cases in screenshots down below.
Data
building_metadata.csv: newca_climate_zonecolumn for all California buildings. DEER buildings use the CEC reference cities, and Los Angeles uses CZ9 (downtown) @jiwonpark-HVAC Important for the next load library update!!locations.csv: San Francisco climate zone corrected from 4C to 3C.UI
Note
If
building_metadata.csvis generated by an external pipeline, theca_climate_zonecolumn has to be added there too.