Skip to content

CATTY-453 Add missing tests for ArduinoDigitalPinFunction #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mariomauberger wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CATTY-453 Add missing tests for ArduinoDigitalPinFunction #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/CattyTests/BluetoothDevices/BluetoothMocks/BluetoothMocks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,3 +208,14 @@ class ArduinoTestMock: ArduinoPropertyProtocol {

internal let arduinoHelper = ArduinoHelper()
}

class ArduinoMock: ArduinoDevice {

override func getDigitalArduinoPin(_ digitalPinNumber: Int) -> Double {
Double(digitalPinNumber)
}

override func getAnalogPin(_ analogPinNumber: Int) -> Double {
Double(analogPinNumber)
}
}
10 changes: 9 additions & 1 deletion src/CattyTests/PlayerEngine/Functions/Arduino/ArduinoAnalogPinFunctionTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* along with this program. If not, see http://www.gnu.org/licenses/.
*/

import BluetoothHelper
import XCTest

@testable import Pocket_Code
Expand Down Expand Up @@ -47,7 +48,14 @@ class ArduinoAnalogPinFunctionTest: XCTestCase {
XCTAssertEqual(type(of: function).defaultValue, function.value(parameter: 0.5 as AnyObject), accuracy: Double.epsilon)
}

// TODO: add testValue() test
func testValue() {
bluetoothService.arduino = ArduinoMock(peripheral: Peripheral(cbPeripheral: PeripheralMock.create(), advertisements: [String: String](), rssi: 0))

let expectedValue = 5
let result = function.value(parameter: expectedValue as AnyObject)
bluetoothService.arduino = nil
XCTAssertEqual(Double(expectedValue), result)
}

func testParameter() {
XCTAssertEqual(.number(defaultValue: 0), function.firstParameter())
Expand Down
10 changes: 9 additions & 1 deletion src/CattyTests/PlayerEngine/Functions/Arduino/ArduinoDigitalPinFunctionTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* along with this program. If not, see http://www.gnu.org/licenses/.
*/

import BluetoothHelper
import XCTest

@testable import Pocket_Code
Expand Down Expand Up @@ -47,7 +48,14 @@ class ArduinoDigitalPinFunctionTest: XCTestCase {
XCTAssertEqual(type(of: function).defaultValue, function.value(parameter: 1.5 as AnyObject), accuracy: Double.epsilon)
}

// TODO: add testValue() test
func testValue() {
bluetoothService.arduino = ArduinoMock(peripheral: Peripheral(cbPeripheral: PeripheralMock.create(), advertisements: [String: String](), rssi: 0))

let expectedValue = 5
let result = function.value(parameter: expectedValue as AnyObject)
bluetoothService.arduino = nil
XCTAssertEqual(Double(expectedValue), result)
}

func testParameter() {
XCTAssertEqual(.number(defaultValue: 0), function.firstParameter())
Expand Down