Refactor StitchAction and its tests to Kotlin (CATROID-1584, CATROID-1585)#5210
Open
harshsomankar123-tech wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Member
Author
|
@reichli @dorianpercic PTAL |
dorianpercic
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related Issues
Description
This PR refactors the
StitchActionclass and its corresponding instrumented testStitchActionTestfrom Java to idiomatic Kotlin.Key Changes
StitchAction.kt:?.) and the Elvis operator (?:) to preventNullPointerExceptions, fulfilling the requirement to eliminate!!assertions in production code.zIndexandembroideryThreadColor.StitchActionTest.kt:lateinit varfor theembroideryPatternManagerMock, allowing for cleanerverifycalls without null-check clutter or!!.zIndexwhich is now safely handled as anInt.General:
Type of Change
How Has This Been Tested?
./gradlew assembleCatroidDebugAndroidTestto ensure all Kotlin components and test dependencies are correctly configured.!!assertions are used in the core logic and that null-safety patterns are correctly applied.Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.