Skip to content

IDE-109: Implement collapseable scripts and composite bricks#5196

Draft
harshsomankar123-tech wants to merge 2 commits into
Catrobat:developfrom
harshsomankar123-tech:feature/IDE-109-collapseable-scripts
Draft

IDE-109: Implement collapseable scripts and composite bricks#5196
harshsomankar123-tech wants to merge 2 commits into
Catrobat:developfrom
harshsomankar123-tech:feature/IDE-109-collapseable-scripts

feat: finalize collapsible scripts with interactive toggles and squas…

a00700d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / detekt succeeded Apr 16, 2026 in 11s

20 new alerts

New alerts in code changed by this pull request

  • 20 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 40 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Detects unused imports Warning

Unused import

Check warning on line 40 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Unused Imports are dead code and should be removed. Warning

The import 'androidx.core.content.ContextCompat' is unused.

Check warning on line 137 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Excessive nesting leads to hidden complexity. Prefer extracting code to make it easier to understand. Warning

Function filterCollapsedCompositeBricks is nested too deeply.

Check warning on line 140 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Detects trailing spaces Warning

Trailing space(s)

Check warning on line 140 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Whitespaces at the end of a line are unnecessary and can be removed. Warning

Line 140 ends with a whitespace.

Check warning on line 145 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

The loop contains more than one break or continue statement. The code should be refactored to increase readability. Warning

The loop contains more than one break or continue statement. The code should be refactored to increase readability.

Check warning on line 148 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 152 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Detects trailing spaces Warning

Trailing space(s)

Check warning on line 152 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Whitespaces at the end of a line are unnecessary and can be removed. Warning

Line 152 ends with a whitespace.

Check warning on line 176 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Detects trailing spaces Warning

Trailing space(s)

Check warning on line 176 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Whitespaces at the end of a line are unnecessary and can be removed. Warning

Line 176 ends with a whitespace.

Check warning on line 189 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 233 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning

The function addCollapseIndicator is too long (99). The maximum length is 80.

Check warning on line 233 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Excessive nesting leads to hidden complexity. Prefer extracting code to make it easier to understand. Warning

Function addCollapseIndicator is nested too deeply.

Check warning on line 304 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 305 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 308 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 311 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 311 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 490 in catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt

See this annotation in the file changed.

Code scanning / detekt

Private function is unused and should be removed. Warning

Private function handleCheckBoxModeCollapseExpand is unused.