CATROID-1627 Bump version of more libraries#5190
Conversation
|
There was a problem hiding this comment.
Pull request overview
Updates Android/Google and third-party dependency versions (notably Lifecycle, Room, Espresso, WebKit, Guava/Gson/androidasync, and LibGDX), with accompanying source changes required for the updated APIs.
Changes:
- Bump versions for several AndroidX/Google and third-party libraries (including LibGDX, Room, Espresso, WebKit, Guava/Gson, androidasync).
- Replace deprecated
lifecycle-extensionsdependency withlifecycle-runtime-ktxand update code to match updated nullability/override expectations. - Adjust
CameraManager’sLifecycleOwnerimplementation to exposelifecyclevia aLifecycleRegistry.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| catroid/src/main/java/org/catrobat/catroid/utils/LiveDataExtensions.kt | Updates Observer callback signature to match updated Lifecycle nullability. |
| catroid/src/main/java/org/catrobat/catroid/scratchconverter/WebSocketClient.java | Modifies WebSocket connection logic (currently comments it out). |
| catroid/src/main/java/org/catrobat/catroid/camera/CameraManager.kt | Renames internal lifecycle field and updates LifecycleOwner override style. |
| catroid/build.gradle | Bumps multiple library versions; replaces lifecycle-extensions with lifecycle-runtime-ktx. |
| build.gradle | Bumps lifecycle_version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -124,7 +125,7 @@ public void onCompleted(Exception ex, final WebSocket newWebSocket) { | |||
| webSocket.setClosedCallback(client); | |||
| connectCallback.onSuccess(); | |||
| } | |||
| }); | |||
| });*/ | |||
| } | |||
There was a problem hiding this comment.
connect() no longer initiates a WebSocket connection or invokes connectCallback (the entire asyncHttpClient.websocket(...) call is commented out). As a result, connectAndAuthenticate() can hang in NOT_CONNECTED without ever calling onSuccess()/onFailure(), effectively breaking Scratch Converter connectivity. Please either migrate this call to the non-deprecated androidasync 3.x WebSocket API (and keep the callbacks/state transitions), or remove/feature-gate Scratch Converter so callers aren’t left waiting silently.



https://catrobat.atlassian.net/browse/CATROID-1627
Increased the version number of some Google/Android libraries as well as LibGDX (1.13.0 -> 1.13.1).
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.