Skip to content

CATROID-1627 Bump version of more libraries#5190

Draft
reichli wants to merge 1 commit into
Catrobat:developfrom
reichli:CATROID-1627
Draft

CATROID-1627 Bump version of more libraries#5190
reichli wants to merge 1 commit into
Catrobat:developfrom
reichli:CATROID-1627

Conversation

@reichli

@reichli reichli commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

https://catrobat.atlassian.net/browse/CATROID-1627

Increased the version number of some Google/Android libraries as well as LibGDX (1.13.0 -> 1.13.1).

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud

sonarqubecloud Bot commented Apr 8, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Android/Google and third-party dependency versions (notably Lifecycle, Room, Espresso, WebKit, Guava/Gson/androidasync, and LibGDX), with accompanying source changes required for the updated APIs.

Changes:

  • Bump versions for several AndroidX/Google and third-party libraries (including LibGDX, Room, Espresso, WebKit, Guava/Gson, androidasync).
  • Replace deprecated lifecycle-extensions dependency with lifecycle-runtime-ktx and update code to match updated nullability/override expectations.
  • Adjust CameraManager’s LifecycleOwner implementation to expose lifecycle via a LifecycleRegistry.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
catroid/src/main/java/org/catrobat/catroid/utils/LiveDataExtensions.kt Updates Observer callback signature to match updated Lifecycle nullability.
catroid/src/main/java/org/catrobat/catroid/scratchconverter/WebSocketClient.java Modifies WebSocket connection logic (currently comments it out).
catroid/src/main/java/org/catrobat/catroid/camera/CameraManager.kt Renames internal lifecycle field and updates LifecycleOwner override style.
catroid/build.gradle Bumps multiple library versions; replaces lifecycle-extensions with lifecycle-runtime-ktx.
build.gradle Bumps lifecycle_version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 106 to 129
@@ -124,7 +125,7 @@ public void onCompleted(Exception ex, final WebSocket newWebSocket) {
webSocket.setClosedCallback(client);
connectCallback.onSuccess();
}
});
});*/
}

Copilot AI Apr 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connect() no longer initiates a WebSocket connection or invokes connectCallback (the entire asyncHttpClient.websocket(...) call is commented out). As a result, connectAndAuthenticate() can hang in NOT_CONNECTED without ever calling onSuccess()/onFailure(), effectively breaking Scratch Converter connectivity. Please either migrate this call to the non-deprecated androidasync 3.x WebSocket API (and keep the callbacks/state transitions), or remove/feature-gate Scratch Converter so callers aren’t left waiting silently.

Copilot uses AI. Check for mistakes.
@reichli reichli added the Active Member Tickets that are assigned to members that are still currently active label May 4, 2026
@reichli reichli marked this pull request as ready for review June 24, 2026 15:08
@reichli reichli marked this pull request as draft June 24, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants