-
-
Notifications
You must be signed in to change notification settings - Fork 129
feat(frontend): promote priority support for Capgo plugins #2828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WcaleNieWolny
wants to merge
8
commits into
main
Choose a base branch
from
wolny/priority-support-plugins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,575
−61
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3ee2531
feat(frontend): promote priority plugin support
WcaleNieWolny 3a0ad4e
fix(frontend): address priority support review feedback
WcaleNieWolny 67d33cc
fix(frontend): harden priority support accessibility
WcaleNieWolny a48415a
fix(frontend): align priority support styling
WcaleNieWolny 498d8b8
fix(frontend): settle priority support motion
WcaleNieWolny 8c54197
fix(frontend): mount GitHub dialog content reliably
WcaleNieWolny 16cef50
fix(frontend): complete priority support handoff
WcaleNieWolny 6a63627
fix(frontend): resolve final priority support review
WcaleNieWolny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { expect, test } from '../support/commands' | ||
|
|
||
| test.describe('Priority plugin support', () => { | ||
| test.beforeEach(async ({ page }) => { | ||
| await page.login('test@capgo.app', 'testtest') | ||
| }) | ||
|
|
||
| test('links GitHub from the priority-support presentation', async ({ page }) => { | ||
| await page.clock.setFixedTime(new Date('2026-08-02T12:00:00.000Z')) | ||
| await page.emulateMedia({ reducedMotion: 'reduce' }) | ||
| await page.goto('/app/com.demo.app') | ||
|
|
||
| const banner = page.getByRole('button', { name: /Priority help for Capgo plugins/ }) | ||
| await expect(banner).toBeVisible() | ||
| const overflowBefore = await page.locator('body').evaluate(body => body.style.overflow) | ||
| await banner.click() | ||
|
|
||
| const presentation = page.getByRole('dialog') | ||
| const progress = presentation.getByRole('progressbar') | ||
| const slides = presentation.locator('.ps-slide') | ||
| await expect(progress).toHaveAttribute('aria-valuenow', '1') | ||
|
|
||
| await presentation.getByRole('button', { name: /^Next/ }).click() | ||
| await expect(progress).toHaveAttribute('aria-valuenow', '2') | ||
| expect(await slides.evaluateAll(elements => elements | ||
| .map((element, index) => ({ index, style: getComputedStyle(element) })) | ||
| .filter(({ style }) => style.visibility !== 'hidden' && Number(style.opacity) > 0.99) | ||
| .map(({ index }) => index))).toEqual([1]) | ||
|
|
||
| await presentation.locator('.ps-x').click() | ||
| await expect(presentation).toBeHidden() | ||
| expect(await page.locator('body').evaluate(body => body.style.overflow)).toBe(overflowBefore) | ||
|
|
||
| await banner.click() | ||
| await expect(progress).toHaveAttribute('aria-valuenow', '1') | ||
| await presentation.getByRole('button', { name: /^Next/ }).click() | ||
| await presentation.getByRole('button', { name: /^Next/ }).click() | ||
| await expect(progress).toHaveAttribute('aria-valuenow', '3') | ||
| await presentation.getByRole('button', { name: 'Link your GitHub account', exact: true }).click() | ||
|
|
||
| await expect(page).toHaveURL(/\/settings\/account\?(?=[^#]*from=priority-support)(?=[^#]*tab=profile)(?![^#]*connect=github)/) | ||
| await expect(page.getByRole('heading', { name: 'GitHub username', exact: true })).toBeVisible() | ||
| await expect(page.locator('#github-username-input')).toBeVisible() | ||
|
|
||
| await page.getByRole('button', { name: 'Cancel', exact: true }).click() | ||
| await expect(page.getByRole('heading', { name: 'GitHub username', exact: true })).not.toBeVisible() | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.