scroll_anchor setting#442
Open
Canop wants to merge 2 commits into
Open
Conversation
Contributor
|
Yeah this makes sense to me. I'll switch to this version and let you know what I think. If you want feedback before I feel I have anything useful just ping me and I'll tell you want I think so far. I don't quite have time to specifically test this but I will switch to this version and let you know how I feel using it. I've overridden the default long run job so I'd need to add the setting to auto to my job right? |
Owner
Author
Yes. All user defined jobs are on "unspecified" which means "first". |
Contributor
|
I added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bacon sorts items, with errors first, followed by warnings.
The first items (on top if you don't have the reverse setting) are usually the most interesting ones.
But not always. For example, with the
runjob, when there's no error and the compiled binary is effectively executed, you may want to focus on the output of the program.And if it's a
long run, you probably want to have the scroll follow the new lines unless you decided to scroll away.This PR introduces the
scroll_anchorsetting, whose value can be undefined,auto,first, orlast.When not defined, the applied default will be
first.In the default
bacon.toml, therunandrun-longjobs havescroll_anchor = "auto"which means that:tailto follow new lines)This should fix #384 but there will be a test period before I try to merge it, or not. Feedback welcome.