Allow configurable snooze duration using SharedPreferences#10
Open
Apprentice2907 wants to merge 1 commit into
Open
Allow configurable snooze duration using SharedPreferences#10Apprentice2907 wants to merge 1 commit into
Apprentice2907 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the PR! I think it would be better to avoid using SharedPreferences here to prevent unnecessary global state and data fragmentation. Since we already have a DB setup, adding a new column/row to the existing table would be more consistent with the current architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the hardcoded snooze duration and introduces a configurable snooze duration using Android SharedPreferences. The default behavior remains unchanged (5 minutes), while allowing future customization.
Type of Change
Proposed Changes
Fixes #(issue_no)
Replace
issue_nowith the issue number which is fixed in this PRFixes #5
Screenshots
Not applicable (logic-level change, no UI updates).
Checklist