Repair issues in 'Reports' generation. - #224
Conversation
|
Hi @henri62, I am unable to replicate the report generation problem with the file that is attached when using git master. Recording.2026-07-25.115941.mp4 |
|
That's strange, maybe I accidentally attached the (xdd) file where I fixed the issue already. Unfortunately our company just started the 3 weeks holiday so I cannot check if the file I attached here breaks the code. You have to wait for about 2 weeks, then I can test it. (And if it doesnt reproduce create the file again) I tried to manually view the file to see if it should reproduce it but cannot see it. So please wait. On june 17th, I reported to root cause of the problem in the original ticket #222 |
|
I tried to reproduce the issue with the original version I encountered the problem first and the file I attached here. (From the opening post of the original bug report #222) On opening the file I get this: The ReportView does not display anything valuable any more: I think that its related to the .NET runtime I upgraded since reporting this issue between (because I was trying to build the project myself) so that the crash manifests this problem in a different way. I will see if I can reproduce the original problem with a minimum file. -EDIT 1- -EDIT 2- Create an SDO 0x2000 with only 1 entry subindex 0x00. I manually recreated/patched the offending file so you can see the final result with my patch above: Of course its a problem in the file that the SDO shall have a subindex 0 that says what the maximum index shall be but at leat the tool should not crash on that. You can also check it easily when making a TPDO mapping that is out of bounds in well defined SDO's, you get the same error. |
Fixes:
Fix an exception in the code when an non-existing subindex is referenced in a TPDO. See Unhandled exception running "Reports->Network PDO". #222 for details and reproduction.
Fix an error when Reports->Documentation is called and you have spaces in your windows profile.
Tested with a file that has a mapping to a non-existing sub-index, it now reports this error in the generated report with a RED colored message (via a style sheet ref) that the subindex is missing. To my opinion no error pop-up or something is needed because the goal is to make a report, so it suits the purpose.
When you have a userprofile that contains spaces the generated temp file path for the *.md file also contains spaces and the viewer pop-up did not show up but gave an error of a missing file. The file is now quoted and the call is "modernized".
I have read the contributing guidelines, I agree to following them and I agree to the Developer's Certificate of Origin 1.1