ci: reintroduce x86-64 test for non-SSE environment#146
Merged
Conversation
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
mkroening
force-pushed
the
non-sse-ci
branch
from
3e4818c to
c45d89b
Compare
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
mkroening
force-pushed
the
non-sse-ci
branch
from
c45d89b to
618abee
Compare
Contributor
Author
|
In a third commit, I have also added a CI test for |
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
mkroening
force-pushed
the
non-sse-ci
branch
from
a2eb63a to
4db9f0d
Compare
Contributor
Author
|
Friendly ping, @BurntSushi :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old CI test was removed (#77 (comment)) due to rust-lang/rust#116672 causing a mismatch of data layouts with the custom target (
src/tests/x86_64-soft_float.json):error: data-layout for target `x86_64-soft_float-10047705440633310713`, `e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128`, differs from LLVM target's `x86_64-unknown-none` default layout, `e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128`This PR removes the unused custom target and reintroduces the CI test with the now-available tier 2 target
x86_64-unknown-none. This makes this test much more robust, since we don't have to update a custom target ourselves and can even use stable Rust now.