fix: 修复 macOS 上 1px 白边问题以及圆角问题#263
Open
CakeAL wants to merge 2 commits into
Open
Conversation
Author
Owner
|
你好呀,非常感谢的 PR. ヾ(≧▽≦*)o 我现在手边没有mac电脑,在 windows 上 review了一下.
如果你愿意的话, 可以 添加一个返回系统类型的函数, ( 这边建议是使用库 能识别具体版本号, 比如 win10 win11, 可能后面还可以搭配 window-vibrancy 添加不同的窗口效果, 例如 blur 然后在前端对这个函数结果进行判断, 如果是 mac 的话就应用相应的 css, 甚至这里也可以直接通过 js 进行修改 element 的 style (root 在 index.html 不太好进行响应式的判断) 也可以将高度的推算进行延后, 比如 root 还是 100% 在 panel 里面进行高度的限制都可以. 这是我的一点想法, 以及再次感谢 |
Author
之后我再修改一下。 关于其他的内容我都愿意尝试,窗口效果的话,可以直接用css实现(甚至可以给用户一个选择,让他们自定义 background),然后搭配上目前的背景透明,如果想用更原生的效果的话,确实使用这个库会更好而且也是支持macOS的(但是这个确实更好,css总觉得不够快)。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.