Skip to content

chore(BaiduSpeech): bump Newtonsoft.Json version to latest - #679

Merged
ArgoZhang merged 1 commit into
masterfrom
chore-baidu
Nov 12, 2025
Merged

ArgoZhang merged 1 commit into
masterfrom
chore-baidu

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Nov 12, 2025 •

Copy link
Copy Markdown
Member

Link issues

fixes #678

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Upgrade Newtonsoft.Json dependency in BaiduSpeech component to the latest version, resolving issue #678.

Bug Fixes:

Build:

  • Bump Newtonsoft.Json package reference to the latest version in BaiduSpeech project

Copilot AI review requested due to automatic review settings November 12, 2025 04:52
@bb-auto bb-auto Bot added the chore label Nov 12, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Nov 12, 2025
@sourcery-ai

sourcery-ai Bot commented Nov 12, 2025 •

Copy link
Copy Markdown

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang
ArgoZhang merged commit 42a6188 into master Nov 12, 2025
3 of 4 checks passed
@ArgoZhang
ArgoZhang deleted the chore-baidu branch November 12, 2025 04:52

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an explicit Newtonsoft.Json package reference to the BaiduSpeech component to resolve issue #678, likely addressing a missing or outdated transitive dependency.

  • Adds Newtonsoft.Json v13.* as a direct dependency to BootstrapBlazor.BaiduSpeech

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<ItemGroup>
<PackageReference Include="Baidu.AI" Version="4.15.16" />
<PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" />
<PackageReference Include="Newtonsoft.Json" Version="13.*" />

Copilot AI Nov 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard version pattern 13.* is inconsistent with other components in the project. Other components like BootstrapBlazor.OCR and BootstrapBlazor.OpenAI.GPT3 use the specific version 13.0.3 for Newtonsoft.Json. Consider using a specific version (e.g., 13.0.3) instead of a wildcard pattern to ensure consistent dependencies across the project and avoid unexpected breaking changes from minor/patch version updates.

Suggested change
<PackageReference Include="Newtonsoft.Json" Version="13.*" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(BaiduSpeech): bump Newtonsoft.Json version to latest

2 participants