Skip to content

fix(JitViewer): fingerprint CSS asset - #1232

Merged
ArgoZhang merged 3 commits into
masterfrom
dev-JitViewer
Oct 23, 2026
Merged

ArgoZhang merged 3 commits into
masterfrom
dev-JitViewer

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #1231

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Support fingerprinted JitViewer CSS asset URLs across supported target frameworks.

Bug Fixes:

  • Ensure the JitViewer CSS asset URL supports fingerprinted paths in .NET 9 and later while preserving compatibility with earlier target frameworks.

Build:

  • Update component project configuration to support the asset URL changes.

@sourcery-ai

sourcery-ai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates JitViewer stylesheet loading to use the .NET 9 asset manifest for fingerprinted CSS URLs, with a backward-compatible static path for older target frameworks, and adjusts related project configuration.

Sequence diagram for fingerprinted JitViewer CSS loading

sequenceDiagram
    participant JitViewer
    participant JitViewerJS
    participant AssetManifest
    participant Browser

    JitViewer->>JitViewer: InvokeInitAsync()
    alt NET9_0_OR_GREATER
        JitViewer->>AssetManifest: Assets[StylePath]
        AssetManifest-->>JitViewer: Fingerprinted CSS URL
    else Older target framework
        JitViewer->>JitViewer: StylePath
    end
    JitViewer->>JitViewerJS: init(id, invoke, options, styleUrl)
    JitViewerJS->>Browser: addLink(styleUrl)
    Browser-->>JitViewerJS: Load JitViewer stylesheet
Loading

File-Level Changes

Change Details Files
Pass a runtime-resolved stylesheet URL into the JitViewer JavaScript initializer so the CSS asset can use framework-generated fingerprints on .NET 9 and later.
  • Define the JitViewer stylesheet asset path and resolve it through the asset manifest on .NET 9+ while retaining the existing static path for earlier targets.
  • Extend JavaScript initialization to accept the stylesheet URL and load it through the shared link helper.
  • Update project configuration for the CherryMarkdown and JitViewer components.
src/components/BootstrapBlazor.CherryMarkdown/BootstrapBlazor.CherryMarkdown.csproj
src/components/BootstrapBlazor.JitViewer/BootstrapBlazor.JitViewer.csproj
src/components/BootstrapBlazor.JitViewer/Components/JitViewer.razor.cs
src/components/BootstrapBlazor.JitViewer/Components/JitViewer.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#1229 Fingerprint the CherryMarkdown CSS asset so it can be referenced with a fingerprinted URL. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 23, 2026
@bb-auto bb-auto Bot added this to the v10.0.0 milestone Oct 23, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit 3201104 into master Oct 23, 2026
3 checks passed
@ArgoZhang
ArgoZhang deleted the dev-JitViewer branch October 23, 2026 02:15

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(JitViewer): fingerprint CSS asset

1 participant